Restructuring NavigationController functionalities from ContentViewCore to NavigationController

content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content_public.browser;

[Yaron, 2014/07/25 16:05:56]

Note the package. This is part of the public interface of the content layer.
It's a bit confusing because currently most java code in content is in
content/public/android but we're trying to separate the public interface from
the one which is internal to content (e.g. NavigationController is public but
NavigationControllerImpl is internal).

LoadUrlParams needs to be part of the public interface. Please move it to
content/public/android/java/src/org/chromium/content_public/browser/
The same is true for NavigationHistory. That will appease the checkdeps
failures. 

[AKVT, 2014/07/26 14:25:08]

Thank you. I have made changes accordingly, but I can see dependency with
NavigationEntry from NavigationHistory and PageTrnasitionTypes from
LoadUrlParams as well. So I am moving NavigationEntry and PageTrnasitionTypes to
content_public folder for resolving compilation issues. Please suggest your
opinion.

[Yaron, 2014/07/28 22:43:39]

I think what you have is good.

 
+import org.chromium.content.browser.LoadUrlParams;
+import org.chromium.content.browser.NavigationHistory;
+
 /**
  * The NavigationController Java wrapper to allow communicating with the native
  * NavigationController object.
  */
 public interface NavigationController {
     /**
      * @return Whether back navigation is possible from the "current entry".
      */
     boolean canGoBack();
 
@@ skipping 53 matching lines @@
 
     /**
      * Cancel the pending reload.
      */
     public void cancelPendingReload();
 
     /**
      * Continue the pending reload.
      */
     public void continuePendingReload();
+
+    /**
+     * Load url without fixing up the url string. Consumers of NavigationController are
+     * responsible for ensuring the URL passed in is properly formatted (i.e. the
+     * scheme has been added if left off during user input).
+     * @param params Parameters for this load.
+     */
+    public void loadUrl(LoadUrlParams params);
+
+    /**
+     * Clears NavigationController's page history in both backwards and
+     * forwards directions.
+     */
+    public void clearHistory();
+
+    /**
+     * Get a copy of the navigation history of NavigationController.
+     * @return navigation history of NavigationController.
+     */
+    public NavigationHistory getNavigationHistory();
+
+    /**
+    * Get the navigation history of NavigationController from current navigation entry index
+    * with direction (forward/backward)
+    * @param isForward determines forward or backward from current index
+    * @param itemLimit maximum number of entries to be retrieved in specified
+    * diection.
+    * @return navigation history by keeping above constraints.
+    */
+    public NavigationHistory getDirectedNavigationHistory(boolean isForward, int itemLimit);
+
+    /**
+     * Get Original URL for current Navigation entry of NavigationController.
+     * @return The original request URL for the current navigation entry, or null if there is no
+     *         current entry.
+     */
+    public String getOriginalUrlForVisibleNavigationEntry();
+
+    /**
+     * Clears SSL preferences for this NavigationController.
+     */
+    public void clearSslPreferences();
+
+    /**
+     * Get whether or not we're using a desktop user agent for the currently loaded page.
+     * @return true, if use a desktop user agent and false for a mobile one.
+     */
+    public boolean getUseDesktopUserAgent();
+
+    /**
+     * Set whether or not we're using a desktop user agent for the currently loaded page.
+     * @param override If true, use a desktop user agent.  Use a mobile one otherwise.
+     * @param reloadOnChange Reload the page if the UA has changed.
+     */
+    public void setUseDesktopUserAgent(boolean override, boolean reloadOnChange);
 }