Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/android/tab_android.cc

Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the unit test build break Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/tab_android.h" 5 #include "chrome/browser/android/tab_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_array.h" 8 #include "base/android/jni_array.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/debug/trace_event.h" 10 #include "base/debug/trace_event.h"
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 427
428 TabAndroid::TabLoadStatus TabAndroid::LoadUrl(JNIEnv* env, 428 TabAndroid::TabLoadStatus TabAndroid::LoadUrl(JNIEnv* env,
429 jobject obj, 429 jobject obj,
430 jstring url, 430 jstring url,
431 jstring j_extra_headers, 431 jstring j_extra_headers,
432 jbyteArray j_post_data, 432 jbyteArray j_post_data,
433 jint page_transition, 433 jint page_transition,
434 jstring j_referrer_url, 434 jstring j_referrer_url,
435 jint referrer_policy, 435 jint referrer_policy,
436 jboolean is_renderer_initiated) { 436 jboolean is_renderer_initiated) {
437 content::ContentViewCore* content_view = GetContentViewCore(); 437 if (!web_contents())
438 if (!content_view)
439 return PAGE_LOAD_FAILED; 438 return PAGE_LOAD_FAILED;
440 439
441 GURL gurl(base::android::ConvertJavaStringToUTF8(env, url)); 440 GURL gurl(base::android::ConvertJavaStringToUTF8(env, url));
442 if (gurl.is_empty()) 441 if (gurl.is_empty())
443 return PAGE_LOAD_FAILED; 442 return PAGE_LOAD_FAILED;
444 443
445 // If the page was prerendered, use it. 444 // If the page was prerendered, use it.
446 // Note in incognito mode, we don't have a PrerenderManager. 445 // Note in incognito mode, we don't have a PrerenderManager.
447 446
448 prerender::PrerenderManager* prerender_manager = 447 prerender::PrerenderManager* prerender_manager =
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 const base::string16 search_terms = 520 const base::string16 search_terms =
522 chrome::ExtractSearchTermsFromURL(GetProfile(), gurl); 521 chrome::ExtractSearchTermsFromURL(GetProfile(), gurl);
523 SearchTabHelper* search_tab_helper = 522 SearchTabHelper* search_tab_helper =
524 SearchTabHelper::FromWebContents(web_contents_.get()); 523 SearchTabHelper::FromWebContents(web_contents_.get());
525 if (!search_terms.empty() && search_tab_helper && 524 if (!search_terms.empty() && search_tab_helper &&
526 search_tab_helper->SupportsInstant()) { 525 search_tab_helper->SupportsInstant()) {
527 search_tab_helper->Submit(search_terms); 526 search_tab_helper->Submit(search_terms);
528 return DEFAULT_PAGE_LOAD; 527 return DEFAULT_PAGE_LOAD;
529 } 528 }
530 load_params.is_renderer_initiated = is_renderer_initiated; 529 load_params.is_renderer_initiated = is_renderer_initiated;
531 content_view->LoadUrl(load_params); 530 web_contents()->GetController().LoadURLWithParams(load_params);
532 } 531 }
533 return DEFAULT_PAGE_LOAD; 532 return DEFAULT_PAGE_LOAD;
534 } 533 }
535 534
536 ToolbarModel::SecurityLevel TabAndroid::GetSecurityLevel(JNIEnv* env, 535 ToolbarModel::SecurityLevel TabAndroid::GetSecurityLevel(JNIEnv* env,
537 jobject obj) { 536 jobject obj) {
538 return ToolbarModelImpl::GetSecurityLevelForWebContents(web_contents()); 537 return ToolbarModelImpl::GetSecurityLevelForWebContents(web_contents());
539 } 538 }
540 539
541 void TabAndroid::SetActiveNavigationEntryTitleForUrl(JNIEnv* env, 540 void TabAndroid::SetActiveNavigationEntryTitleForUrl(JNIEnv* env,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
581 580
582 static void Init(JNIEnv* env, jobject obj) { 581 static void Init(JNIEnv* env, jobject obj) {
583 TRACE_EVENT0("native", "TabAndroid::Init"); 582 TRACE_EVENT0("native", "TabAndroid::Init");
584 // This will automatically bind to the Java object and pass ownership there. 583 // This will automatically bind to the Java object and pass ownership there.
585 new TabAndroid(env, obj); 584 new TabAndroid(env, obj);
586 } 585 }
587 586
588 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) { 587 bool TabAndroid::RegisterTabAndroid(JNIEnv* env) {
589 return RegisterNativesImpl(env); 588 return RegisterNativesImpl(env);
590 } 589 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698