Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 405983004: Notify RenderWidgetHostView before ScreenOrientationDispatcherHost. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Notify RenderWidgetHostView before ScreenOrientationDispatcherHost. ... in order to have the orientation values updated before the promise gets resolved. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284457

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mlamouri (slow - plz ping)
6 years, 5 months ago (2014-07-21 15:24:50 UTC) #1
mlamouri (slow - plz ping)
6 years, 5 months ago (2014-07-21 15:24:51 UTC) #2
Ted C
lgtm
6 years, 5 months ago (2014-07-21 15:39:47 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 5 months ago (2014-07-21 15:41:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/405983004/1
6 years, 5 months ago (2014-07-21 15:42:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 17:41:00 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 17:51:21 UTC) #7
Message was sent while issue was closed.
Change committed as 284457

Powered by Google App Engine
This is Rietveld 408576698