Copy the PGO runtime library to the release directory (take 2)

Copy the PGO runtime library to the release directory (take 2)

This is a reland of https://codereview.chromium.org/402993002/ with an additional check to make sure that the DLLs exist before trying to copy them.

BUG=395183
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284550

[Sébastien Marchand, 2014-07-21 14:32:58]

PTAL.

[scottmg, 2014-07-21 17:06:19]

I'm sorry I missed this last time, I skimmed the copy_runtime_impl and saw
.exists and didn't really read it.

lgtm

[scottmg, 2014-07-21 17:07:40]

https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:124: if os.path.exists(source_x86):
oops, this should be _x64

[Sébastien Marchand, 2014-07-21 18:29:08]

Thanks, committing.

https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py#newcod...
build/vs_toolchain.py:124: if os.path.exists(source_x86):
On 2014/07/21 17:07:40, scottmg wrote:
> oops, this should be _x64

oops, good catch thanks.

[Sébastien Marchand, 2014-07-21 18:29:13]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:30:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/405983003/20001

[commit-bot: I haz the power, 2014-07-21 20:24:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/35521)

[commit-bot: I haz the power, 2014-07-21 21:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 21:17:13]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Sébastien Marchand, 2014-07-21 21:19:03]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2014-07-21 21:20:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/405983003/20001

[commit-bot: I haz the power, 2014-07-22 00:18:35]

Change committed as 284550