Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 405983003: Copy the PGO runtime library to the release directory (take 2) (Closed)

Created:
6 years, 5 months ago by Sébastien Marchand
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy the PGO runtime library to the release directory (take 2) This is a reland of https://codereview.chromium.org/402993002/ with an additional check to make sure that the DLLs exist before trying to copy them. BUG=395183 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284550

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix cut&paste error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M build/vs_toolchain.py View 1 3 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sébastien Marchand
PTAL.
6 years, 5 months ago (2014-07-21 14:32:58 UTC) #1
scottmg
I'm sorry I missed this last time, I skimmed the copy_runtime_impl and saw .exists and ...
6 years, 5 months ago (2014-07-21 17:06:19 UTC) #2
scottmg
https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py#newcode124 build/vs_toolchain.py:124: if os.path.exists(source_x86): oops, this should be _x64
6 years, 5 months ago (2014-07-21 17:07:40 UTC) #3
Sébastien Marchand
Thanks, committing. https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/405983003/diff/1/build/vs_toolchain.py#newcode124 build/vs_toolchain.py:124: if os.path.exists(source_x86): On 2014/07/21 17:07:40, scottmg wrote: ...
6 years, 5 months ago (2014-07-21 18:29:08 UTC) #4
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 5 months ago (2014-07-21 18:29:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/405983003/20001
6 years, 5 months ago (2014-07-21 18:30:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:24:05 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:17:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41232)
6 years, 5 months ago (2014-07-21 21:17:13 UTC) #9
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 5 months ago (2014-07-21 21:19:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/405983003/20001
6 years, 5 months ago (2014-07-21 21:20:20 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:18:35 UTC) #12
Message was sent while issue was closed.
Change committed as 284550

Powered by Google App Engine
This is Rietveld 408576698