Remove the deprecated NSSCertDatabase::GetInstance() .

net/cert/nss_cert_database_chromeos.cc

Index: net/cert/nss_cert_database_chromeos.cc
diff --git a/net/cert/nss_cert_database_chromeos.cc b/net/cert/nss_cert_database_chromeos.cc
index 41852a742a73bc72c8ec3d5a8130d6e15bc0a452..7236e80c603f54fb9c01c1bd8b1d1ab8a6d9fae4 100644
--- a/net/cert/nss_cert_database_chromeos.cc
+++ b/net/cert/nss_cert_database_chromeos.cc
@@ -21,7 +21,8 @@ namespace net {
 NSSCertDatabaseChromeOS::NSSCertDatabaseChromeOS(
     crypto::ScopedPK11Slot public_slot,
     crypto::ScopedPK11Slot private_slot)
-    : public_slot_(public_slot.Pass()),
+    : NSSCertDatabase(crypto::ScopedPK11Slot() /* no persistent slot */),

[Ryan Sleevi, 2014/07/22 08:31:58]

Why is there no persistent slot for the ChromeOS?

What does it mean to SetCertTrust on an NSSCertDatabaseChromeOS? That violates
the API contract, doesn't it?

Why isn't it just public_slot?

[pneubeck (no reviews), 2014/07/22 09:51:50]

We only run into issues here because the current Linux impl (only one slot) is
different from the ChromeOS impl (pub + priv slot), but the ChromeOS impl is
deriving from the Linux impl and overrides impl of the Linux impl. This is
probably the worst kind of inheritance.

For now we have to make the best out of it. Since we agreed that we don't want
to deviate ChromeOS impl even more from the Linux one, I change this to two
members in the Linux impl.

+      public_slot_(public_slot.Pass()),
       private_slot_(private_slot.Pass()) {
   profile_filter_.Init(GetPublicSlot(), GetPrivateSlot());
 }