Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 405963004: Remove Media.AcceleratedCompositingActive UMA. (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove Media.AcceleratedCompositingActive UMA. With compositing enabled by default this UMA always reports "active". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284588

Patch Set 1 #

Patch Set 2 : obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
scherkus (not reviewing)
6 years, 5 months ago (2014-07-21 18:35:49 UTC) #1
DaleCurtis
lgtm
6 years, 5 months ago (2014-07-21 18:36:37 UTC) #2
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-21 18:36:51 UTC) #3
DaleCurtis
Probably want to check with UMA team before submitting since I don't think we typically ...
6 years, 5 months ago (2014-07-21 18:37:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/405963004/1
6 years, 5 months ago (2014-07-21 18:38:07 UTC) #5
scherkus (not reviewing)
isherman: can you review histograms?
6 years, 5 months ago (2014-07-21 18:46:50 UTC) #6
Ilya Sherman
Please mark the histogram as <obsolete> instead.
6 years, 5 months ago (2014-07-21 20:37:22 UTC) #7
scherkus (not reviewing)
PTAL
6 years, 5 months ago (2014-07-21 20:43:14 UTC) #8
Ilya Sherman
LGTM. Thanks for the cleanup :)
6 years, 5 months ago (2014-07-21 20:45:34 UTC) #9
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-21 20:45:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/405963004/20001
6 years, 5 months ago (2014-07-21 20:46:24 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 01:41:29 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:58:57 UTC) #13
Message was sent while issue was closed.
Change committed as 284588

Powered by Google App Engine
This is Rietveld 408576698