Issue 405933002: Handle a terminating context in messageHandlerInWorker().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405933002: Handle a terminating context in messageHandlerInWorker(). (Closed)

Created:
6 years, 5 months ago by sof

Modified:
6 years, 5 months ago

Reviewers:
haraken, jochen (gone - plz use gerrit)

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Handle a terminating context in messageHandlerinWorker(). If execution is terminated while constructing the ErrorEvent representing the incoming v8::Message, do not attempt to report the exception. R=haraken@chromium.org BUG=393273 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178929

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	Source/bindings/core/v8/V8Initializer.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

sof

Please take a look. No test included here; a semi-reliable repro is available via the ...

6 years, 5 months ago (2014-07-25 10:54:53 UTC) #1

haraken

I'm not sure if this is the only place where we need to insert IsExecutionTerminating() ...

6 years, 5 months ago (2014-07-25 10:57:51 UTC) #3

sof

On 2014/07/25 10:57:51, haraken wrote: > I'm not sure if this is the only place ...

6 years, 5 months ago (2014-07-25 11:02:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/405933002/1

6 years, 5 months ago (2014-07-25 11:18:53 UTC) #6

Message was sent while issue was closed.

Change committed as 178929