Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 40593002: Revert "Separate HTypeConversion checked type from output type." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
index c72124e7fe92f54b838695329bb3fc37f6b2b1ff..7b7616833ed6b0fc067f16c7e21f2d1bc79c32ca 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
@@ -2251,7 +2251,6 @@ class HTypeConversion extends HCheck {
final int kind;
final Selector receiverTypeCheckSelector;
final bool contextIsTypeArguments;
- HType checkedType; // Not final because we refine it.
static const int CHECKED_MODE_CHECK = 0;
static const int ARGUMENT_TYPE_CHECK = 1;
@@ -2263,7 +2262,6 @@ class HTypeConversion extends HCheck {
HType type, HInstruction input,
[this.receiverTypeCheckSelector])
: contextIsTypeArguments = false,
- checkedType = type,
super(<HInstruction>[input]) {
assert(!isReceiverTypeCheck || receiverTypeCheckSelector != null);
assert(typeExpression == null ||
@@ -2276,7 +2274,6 @@ class HTypeConversion extends HCheck {
HType type, HInstruction input,
HInstruction typeRepresentation)
: contextIsTypeArguments = false,
- checkedType = type,
super(<HInstruction>[input, typeRepresentation]),
receiverTypeCheckSelector = null {
assert(typeExpression.kind != TypeKind.TYPEDEF);
@@ -2289,7 +2286,6 @@ class HTypeConversion extends HCheck {
HInstruction context,
{bool this.contextIsTypeArguments})
: super(<HInstruction>[input, context]),
- checkedType = type,
receiverTypeCheckSelector = null {
assert(typeExpression.kind != TypeKind.TYPEDEF);
sourceElement = input.sourceElement;
@@ -2332,7 +2328,7 @@ class HTypeConversion extends HCheck {
bool dataEquals(HTypeConversion other) {
return kind == other.kind
&& typeExpression == other.typeExpression
- && checkedType == other.checkedType;
+ && instructionType == other.instructionType;
}
}

Powered by Google App Engine
This is Rietveld 408576698