Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 405923002: Introduce DEFINE_ELEMENT_DATA_TYPE_CASTS, and use it (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent, Inactive
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce DEFINE_ELEMENT_DATA_TYPE_CASTS, and use it As a step to use toFoo, this cl introduces DEFINE_ELEMENT_DATA_TYPE_CASTS, which generates toUniqueElementData() and toShareableElementData(). Those functions will detect bad type cast. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178643

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ElementData.h View 1 2 3 4 4 chunks +11 lines, -3 lines 0 comments Download
M Source/core/dom/ElementData.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-21 10:59:40 UTC) #1
Inactive
https://codereview.chromium.org/405923002/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/405923002/diff/1/Source/core/dom/Element.cpp#newcode3120 Source/core/dom/Element.cpp:3120: const_cast<Element&>(other).m_elementData = toUniqueElementData(other.m_elementData.get())->makeShareableCopy(); nit: Do we still need the ...
6 years, 5 months ago (2014-07-21 12:14:00 UTC) #2
gyuyoung-inactive
https://codereview.chromium.org/405923002/diff/1/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/405923002/diff/1/Source/core/dom/Element.cpp#newcode3120 Source/core/dom/Element.cpp:3120: const_cast<Element&>(other).m_elementData = toUniqueElementData(other.m_elementData.get())->makeShareableCopy(); On 2014/07/21 12:14:00, Chris Dumez wrote: ...
6 years, 5 months ago (2014-07-21 13:04:08 UTC) #3
Inactive
https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h#newcode116 Source/core/dom/ElementData.h:116: template<typename T> inline thisType* to##thisType(const RefPtr<T>& data) { return ...
6 years, 5 months ago (2014-07-21 19:37:48 UTC) #4
gyuyoung-inactive
https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h#newcode116 Source/core/dom/ElementData.h:116: template<typename T> inline thisType* to##thisType(const RefPtr<T>& data) { return ...
6 years, 5 months ago (2014-07-22 00:20:33 UTC) #5
Inactive
https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h#newcode116 Source/core/dom/ElementData.h:116: template<typename T> inline thisType* to##thisType(const RefPtr<T>& data) { return ...
6 years, 5 months ago (2014-07-22 00:44:29 UTC) #6
tkent
https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/20001/Source/core/dom/ElementData.h#newcode116 Source/core/dom/ElementData.h:116: template<typename T> inline thisType* to##thisType(const RefPtr<T>& data) { return ...
6 years, 5 months ago (2014-07-22 00:57:13 UTC) #7
gyuyoung-inactive
https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h#newcode152 Source/core/dom/ElementData.h:152: DEFINE_ELEMENT_DATA_TYPE_CASTS(ShareableElementData, isUnique() == 0); Ok, what do you guys ...
6 years, 5 months ago (2014-07-22 02:09:52 UTC) #8
tkent
https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h#newcode152 Source/core/dom/ElementData.h:152: DEFINE_ELEMENT_DATA_TYPE_CASTS(ShareableElementData, isUnique() == 0); On 2014/07/22 02:09:52, gyuyoung wrote: ...
6 years, 5 months ago (2014-07-22 03:19:31 UTC) #9
gyuyoung-inactive
https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h File Source/core/dom/ElementData.h (right): https://codereview.chromium.org/405923002/diff/40001/Source/core/dom/ElementData.h#newcode152 Source/core/dom/ElementData.h:152: DEFINE_ELEMENT_DATA_TYPE_CASTS(ShareableElementData, isUnique() == 0); On 2014/07/22 03:19:31, tkent wrote: ...
6 years, 5 months ago (2014-07-22 03:46:19 UTC) #10
tkent
Have you run any tests with Patch Set 4?
6 years, 5 months ago (2014-07-22 05:13:23 UTC) #11
gyuyoung-inactive
On 2014/07/22 05:13:23, tkent wrote: > Have you run any tests with Patch Set 4?
6 years, 5 months ago (2014-07-22 06:12:00 UTC) #12
gyuyoung-inactive
On 2014/07/22 06:12:00, gyuyoung wrote: > On 2014/07/22 05:13:23, tkent wrote: > > Have you ...
6 years, 5 months ago (2014-07-22 06:12:51 UTC) #13
tkent
lgtm
6 years, 5 months ago (2014-07-22 06:25:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/405923002/70001
6 years, 5 months ago (2014-07-22 06:25:21 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 07:29:42 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 08:16:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18147)
6 years, 5 months ago (2014-07-22 08:16:59 UTC) #18
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-22 10:32:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/405923002/70001
6 years, 5 months ago (2014-07-22 10:33:37 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 11:38:19 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 12:23:02 UTC) #22
Message was sent while issue was closed.
Change committed as 178643

Powered by Google App Engine
This is Rietveld 408576698