Java core implementation: ensure correct alignment.

mojo/android/system/core_impl.cc

Index: mojo/android/system/core_impl.cc
diff --git a/mojo/android/system/core_impl.cc b/mojo/android/system/core_impl.cc
index 36b28dce830b80852743bc1225bca0035bf640e2..9861f5276739599598edfcaffba8b36dbce5e95f 100644
--- a/mojo/android/system/core_impl.cc
+++ b/mojo/android/system/core_impl.cc
@@ -64,6 +64,7 @@ static jint WaitMany(JNIEnv* env,
   // Buffer contains first the list of handles, then the list of signals.
   const void* buffer_start = env->GetDirectBufferAddress(buffer);
   DCHECK(buffer_start);
+  DCHECK_EQ(0, reinterpret_cast<const uintptr_t>(buffer_start) % 8);

[viettrungluu, 2014/07/21 17:12:29]

Nit (here and everywhere else): No need for |const| here.

Also, it's probably also more natural to write it as |DCHECK(..., 0);|.

[qsr, 2014/07/22 08:15:11]

Done.

   const size_t record_size = 8;
   const size_t buffer_size = env->GetDirectBufferCapacity(buffer);
   DCHECK_EQ(buffer_size % record_size, 0u);
@@ -82,6 +83,7 @@ static jobject CreateMessagePipe(JNIEnv* env,
   if (options_buffer) {
     const void* buffer_start = env->GetDirectBufferAddress(options_buffer);
     DCHECK(buffer_start);
+    DCHECK_EQ(0, reinterpret_cast<const uintptr_t>(buffer_start) % 8);
     const size_t buffer_size = env->GetDirectBufferCapacity(options_buffer);
     DCHECK_EQ(buffer_size, sizeof(MojoCreateMessagePipeOptions));
     options = static_cast<const MojoCreateMessagePipeOptions*>(buffer_start);
@@ -101,6 +103,7 @@ static jobject CreateDataPipe(JNIEnv* env,
   if (options_buffer) {
     const void* buffer_start = env->GetDirectBufferAddress(options_buffer);
     DCHECK(buffer_start);
+    DCHECK_EQ(0, reinterpret_cast<const uintptr_t>(buffer_start) % 8);
     const size_t buffer_size = env->GetDirectBufferCapacity(options_buffer);
     DCHECK_EQ(buffer_size, sizeof(MojoCreateDataPipeOptions));
     options = static_cast<const MojoCreateDataPipeOptions*>(buffer_start);
@@ -121,6 +124,7 @@ static jobject CreateSharedBuffer(JNIEnv* env,
   if (options_buffer) {
     const void* buffer_start = env->GetDirectBufferAddress(options_buffer);
     DCHECK(buffer_start);
+    DCHECK_EQ(0, reinterpret_cast<const uintptr_t>(buffer_start) % 8);
     const size_t buffer_size = env->GetDirectBufferCapacity(options_buffer);
     DCHECK_EQ(buffer_size, sizeof(MojoCreateSharedBufferOptions));
     options = static_cast<const MojoCreateSharedBufferOptions*>(buffer_start);