Java core implementation: ensure correct alignment.

Java core implementation: ensure correct alignment.

Ensures that buffer received from the java side are correctly aligned.

R=viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284672

[viettrungluu, 2014-07-21 17:12:30]

LGTM w/nits

https://codereview.chromium.org/405893004/diff/1/mojo/android/system/core_imp...
File mojo/android/system/core_impl.cc (right):

https://codereview.chromium.org/405893004/diff/1/mojo/android/system/core_imp...
mojo/android/system/core_impl.cc:67: DCHECK_EQ(0, reinterpret_cast<const
uintptr_t>(buffer_start) % 8);
Nit (here and everywhere else): No need for |const| here.

Also, it's probably also more natural to write it as |DCHECK(..., 0);|.

[qsr, 2014-07-22 08:15:12]

https://chromiumcodereview.appspot.com/405893004/diff/1/mojo/android/system/c...
File mojo/android/system/core_impl.cc (right):

https://chromiumcodereview.appspot.com/405893004/diff/1/mojo/android/system/c...
mojo/android/system/core_impl.cc:67: DCHECK_EQ(0, reinterpret_cast<const
uintptr_t>(buffer_start) % 8);
On 2014/07/21 17:12:29, viettrungluu wrote:
> Nit (here and everywhere else): No need for |const| here.
> 
> Also, it's probably also more natural to write it as |DCHECK(..., 0);|.

Done.

[qsr, 2014-07-22 08:15:15]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-07-22 08:15:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/405893004/20001

[commit-bot: I haz the power, 2014-07-22 10:13:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 10:19:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:19:02]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[qsr, 2014-07-22 10:43:28]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:45:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/405893004/40001

[commit-bot: I haz the power, 2014-07-22 12:43:10]

Change committed as 284672