Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 405893003: Predeclare globals required by the test framework to avoid walking the prototype chain. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Predeclare globals required by the test framework to avoid walking the prototype chain. Otherwise http/tests/security/xss-DENIED-method-with-iframe-proto.html double-faults while trying to read those global variables that aren't declared. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178553

Patch Set 1 #

Patch Set 2 : Don't assign false since it may conflict with manual configuration #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M LayoutTests/resources/js-test.js View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-21 10:30:18 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-21 10:32:14 UTC) #2
Toon Verwaest
The CQ bit was checked by verwaest@chromium.org
6 years, 5 months ago (2014-07-21 10:32:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/verwaest@chromium.org/405893003/1
6 years, 5 months ago (2014-07-21 10:32:59 UTC) #4
Toon Verwaest
The CQ bit was checked by verwaest@chromium.org
6 years, 5 months ago (2014-07-21 11:16:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/verwaest@chromium.org/405893003/40001
6 years, 5 months ago (2014-07-21 11:17:01 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-21 11:26:00 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 12:16:48 UTC) #8
Message was sent while issue was closed.
Change committed as 178553

Powered by Google App Engine
This is Rietveld 408576698