Fix a null pointer dereference in CreateProfileHandler

Fix a null pointer dereference in CreateProfileHandler::ShowProfileCreationError.

The ProfileManager can call its callback (which points to CreateProfileHandler::OnProfileCreated) with a NULL profile (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/profiles/profile_manager.cc&l=397). This case was not handled in CreateProfileHandler::ShowProfileCreationError.

BUG=395558
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284667

[Marc Treib, 2014-07-21 14:32:03]

PTAL!

[noms (inactive), 2014-07-21 14:41:24]

https://codereview.chromium.org/405883003/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/create_profile_handler.cc (right):

https://codereview.chromium.org/405883003/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/create_profile_handler.cc:286: if (profile)
Would you mind adding a comment as to why this can be null, please?

[Bernhard Bauer, 2014-07-21 14:45:27]

LGTM modulo noms' comment.

[Marc Treib, 2014-07-21 15:07:20]

https://codereview.chromium.org/405883003/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/create_profile_handler.cc (right):

https://codereview.chromium.org/405883003/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/create_profile_handler.cc:286: if (profile)
On 2014/07/21 14:41:24, Monica Dinculescu wrote:
> Would you mind adding a comment as to why this can be null, please?

I've added a somewhat generic comment. Wouldn't want to be too specific, since
then the comment's bound to get out of sync with the ProfileManager code.
(There's already a second place in the ProfileManager that runs its callbacks
with a NULL profile:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...)

[Marc Treib, 2014-07-22 08:01:49]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-07-22 08:02:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/treib@chromium.org/405883003/20001

[commit-bot: I haz the power, 2014-07-22 09:55:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-22 12:14:33]

Change committed as 284667