Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: sdk/lib/_internal/compiler/implementation/source_file.dart

Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/source_file.dart
diff --git a/sdk/lib/_internal/compiler/implementation/source_file.dart b/sdk/lib/_internal/compiler/implementation/source_file.dart
index 25f2afbf708d06b196bb3dabfe3901c778f9cbcd..45636ea7b13360f0a786a358f9e6234a5c2c92bc 100644
--- a/sdk/lib/_internal/compiler/implementation/source_file.dart
+++ b/sdk/lib/_internal/compiler/implementation/source_file.dart
@@ -34,7 +34,7 @@ abstract class SourceFile {
* Sets the string length of this source file. For source files based on UTF-8
* byte arrays, the string length is computed and assigned by the scanner.
*/
- set length(v);
+ set length(int v);
/**
* A map from line numbers to offsets in the string text representation of
@@ -57,7 +57,7 @@ abstract class SourceFile {
* source file had one more empty line at the end. This simplifies the binary
* search in [getLine].
*/
- set lineStarts(v) => lineStartsCache = v;
+ set lineStarts(List<int> v) => lineStartsCache = v;
List<int> lineStartsCache;
@@ -173,7 +173,7 @@ class Utf8BytesSourceFile extends SourceFile {
}
return lengthCache;
}
- set length(v) => lengthCache = v;
+ set length(int v) => lengthCache = v;
int lengthCache = -1;
}
@@ -184,7 +184,7 @@ class StringSourceFile extends SourceFile {
StringSourceFile(String filename, this.text) : super(filename);
int get length => text.length;
- set length(v) { }
+ set length(int v) { }
String slowText() => text;
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/utf8_bytes_scanner.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698