Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/backend.dart

Issue 40583002: Incorporates feedback by Nicolas for UTF-8 bytes based scanner CL (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 class JavaScriptItemCompilationContext extends ItemCompilationContext { 7 class JavaScriptItemCompilationContext extends ItemCompilationContext {
8 final Set<HInstruction> boundsChecked; 8 final Set<HInstruction> boundsChecked;
9 9
10 JavaScriptItemCompilationContext() 10 JavaScriptItemCompilationContext()
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 new TypeMask.nonNullSubtype(jsIndexableClass)); 619 new TypeMask.nonNullSubtype(jsIndexableClass));
620 readableArrayType = new HBoundedType( 620 readableArrayType = new HBoundedType(
621 new TypeMask.nonNullSubclass(jsArrayClass)); 621 new TypeMask.nonNullSubclass(jsArrayClass));
622 mutableArrayType = new HBoundedType( 622 mutableArrayType = new HBoundedType(
623 new TypeMask.nonNullSubclass(jsMutableArrayClass)); 623 new TypeMask.nonNullSubclass(jsMutableArrayClass));
624 fixedArrayType = new HBoundedType( 624 fixedArrayType = new HBoundedType(
625 new TypeMask.nonNullExact(jsFixedArrayClass)); 625 new TypeMask.nonNullExact(jsFixedArrayClass));
626 extendableArrayType = new HBoundedType( 626 extendableArrayType = new HBoundedType(
627 new TypeMask.nonNullExact(jsExtendableArrayClass)); 627 new TypeMask.nonNullExact(jsExtendableArrayClass));
628 628
629 typeVariableClass = 629 typeVariableClass = compiler.findHelper('TypeVariable');
630 compiler.findHelper('TypeVariable');
631 } 630 }
632 631
633 void validateInterceptorImplementsAllObjectMethods( 632 void validateInterceptorImplementsAllObjectMethods(
634 ClassElement interceptorClass) { 633 ClassElement interceptorClass) {
635 if (interceptorClass == null) return; 634 if (interceptorClass == null) return;
636 interceptorClass.ensureResolved(compiler); 635 interceptorClass.ensureResolved(compiler);
637 compiler.objectClass.forEachMember((_, Element member) { 636 compiler.objectClass.forEachMember((_, Element member) {
638 if (member.isGenerativeConstructor()) return; 637 if (member.isGenerativeConstructor()) return;
639 Element interceptorMember = interceptorClass.lookupMember(member.name); 638 Element interceptorMember = interceptorClass.lookupMember(member.name);
640 // Interceptors must override all Object methods due to calling convention 639 // Interceptors must override all Object methods due to calling convention
(...skipping 1216 matching lines...) Expand 10 before | Expand all | Expand 10 after
1857 copy(constant.values); 1856 copy(constant.values);
1858 copy(constant.protoValue); 1857 copy(constant.protoValue);
1859 copy(constant); 1858 copy(constant);
1860 } 1859 }
1861 1860
1862 void visitConstructed(ConstructedConstant constant) { 1861 void visitConstructed(ConstructedConstant constant) {
1863 copy(constant.fields); 1862 copy(constant.fields);
1864 copy(constant); 1863 copy(constant);
1865 } 1864 }
1866 } 1865 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698