Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 405803004: [DevTools] Move device mode button to AdvancedApp and add shortcut. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Move device mode button to AdvancedApp and add shortcut. BUG=395512 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -50 lines) Patch
M Source/devtools/front_end/main/AdvancedApp.js View 3 chunks +80 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/App.js View 3 chunks +0 lines, -49 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-21 09:09:19 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-22 16:37:00 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-22 16:48:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/405803004/1
6 years, 5 months ago (2014-07-22 16:48:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 17:52:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 18:30:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30904)
6 years, 5 months ago (2014-07-22 18:30:58 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-23 05:18:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/405803004/1
6 years, 5 months ago (2014-07-23 05:19:46 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 05:20:36 UTC) #10
Message was sent while issue was closed. 
Change committed as 178733

Powered by Google App Engine
This is Rietveld 408576698