Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: trunk/src/mojo/services/view_manager/view_manager_unittest.cc

Issue 405803002: Revert 284322 "Allow EmbedRoot to be called multiple times." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/mojo/services/view_manager/view_manager_init_service_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/mojo/services/view_manager/view_manager_unittest.cc
===================================================================
--- trunk/src/mojo/services/view_manager/view_manager_unittest.cc (revision 284322)
+++ trunk/src/mojo/services/view_manager/view_manager_unittest.cc (working copy)
@@ -318,7 +318,7 @@
connection_.set_view_manager(client());
}
- // ViewManagerClient:
+ // ViewMangerClient:
virtual void OnViewManagerConnectionEstablished(
ConnectionSpecificId connection_id,
const String& creator_url,
@@ -363,9 +363,6 @@
}
virtual void OnFocusChanged(Id gained_focus_id,
Id lost_focus_id) OVERRIDE {}
- virtual void EmbedRoot(const String& url) OVERRIDE {
- tracker_.OnEmbedRoot(url);
- }
virtual void DispatchOnViewInputEvent(Id view_id,
mojo::EventPtr event) OVERRIDE {
}
@@ -520,12 +517,6 @@
DISALLOW_COPY_AND_ASSIGN(ViewManagerTest);
};
-TEST_F(ViewManagerTest, SecondEmbedRoot) {
- ASSERT_TRUE(EmbedRoot(view_manager_init_.get(), kTestServiceURL));
- connection_->DoRunLoopUntilChangesCount(1);
- EXPECT_EQ(kTestServiceURL, connection_->changes()[0].embed_url);
-}
-
// Verifies client gets a valid id.
TEST_F(ViewManagerTest, ValidId) {
// TODO(beng): this should really have the URL of the application that
« no previous file with comments | « trunk/src/mojo/services/view_manager/view_manager_init_service_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698