Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: ui/webui/resources/js/template_data_externs.js

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: done for tonight Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/template_data_externs.js
diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java b/ui/webui/resources/js/template_data_externs.js
similarity index 59%
copy from mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
copy to ui/webui/resources/js/template_data_externs.js
index 0b8592d52a4ecbd40ca8f57f622100302eee0ac7..9c3dd452687e44f3538cc294a0e82dae7847baa1 100644
--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
+++ b/ui/webui/resources/js/template_data_externs.js
@@ -2,11 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.mojo.bindings;
-
/**
- * Base class for mojo generated interfaces.
+ * @fileoverview Externs for |templateData| global.
+ * @externs
*/
-public interface Interface {
-}
+/** @type {!Object|undefined} */
+window.templateData;
arv (Not doing code reviews) 2014/07/24 16:44:24 can this be? var templateData;
Dan Beam 2014/07/25 01:52:33 it could've but I felt using `window.templateData`
arv (Not doing code reviews) 2014/07/25 18:27:13 It seems like a ReferenceError might be able to ca
Dan Beam 2014/07/25 21:58:18 very well, var templateData it is! :)

Powered by Google App Engine
This is Rietveld 408576698