ui/webui/resources/js/i18n_process.js - Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/i18n_process.js

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: done for tonight Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/js/i18n_process.js

diff --git a/ui/webui/resources/js/i18n_process.js b/ui/webui/resources/js/i18n_process.js

index d33e90cc5af15421151f9cb9d28eaad524b56122..4097973b856ff0a4e00c20c60fce27dcbbf84510 100644

--- a/ui/webui/resources/js/i18n_process.js

+++ b/ui/webui/resources/js/i18n_process.js

@@ -3,4 +3,4 @@

// found in the LICENSE file.

// Invoke the template engine previously loaded from i18n_template.js

-i18nTemplate.process(document, templateData);

+i18nTemplate.process(document, window.templateData);

arv (Not doing code reviews) 2014/07/24 16:44:24 Why is this change needed?

Dan Beam 2014/07/25 01:52:33 less potential reference errors