Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: chrome/browser/resources/ntp4/tile_page.js

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr.isMac fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('ntp', function() { 5 cr.define('ntp', function() {
6 'use strict'; 6 'use strict';
7 7
8 // We can't pass the currently dragging tile via dataTransfer because of 8 // We can't pass the currently dragging tile via dataTransfer because of
9 // http://crbug.com/31037 9 // http://crbug.com/31037
10 var currentlyDraggingTile = null; 10 var currentlyDraggingTile = null;
(...skipping 1354 matching lines...) Expand 10 before | Expand all | Expand 10 after
1365 return false; 1365 return false;
1366 }, 1366 },
1367 1367
1368 /** 1368 /**
1369 * Called to accept a drag drop. Will not be called for in-page drops. 1369 * Called to accept a drag drop. Will not be called for in-page drops.
1370 * @param {Object} dataTransfer The data transfer object that holds the drop 1370 * @param {Object} dataTransfer The data transfer object that holds the drop
1371 * data. This should only be used if currentlyDraggingTile is null. 1371 * data. This should only be used if currentlyDraggingTile is null.
1372 * @param {number} index The tile index at which the drop occurred. 1372 * @param {number} index The tile index at which the drop occurred.
1373 */ 1373 */
1374 addDragData: function(dataTransfer, index) { 1374 addDragData: function(dataTransfer, index) {
1375 assert(false); 1375 assertNotReached();
1376 }, 1376 },
1377 1377
1378 /** 1378 /**
1379 * Called when a tile has been moved (via dragging). Override this to make 1379 * Called when a tile has been moved (via dragging). Override this to make
1380 * backend updates. 1380 * backend updates.
1381 * @param {Node} draggedTile The tile that was dropped. 1381 * @param {Node} draggedTile The tile that was dropped.
1382 * @param {number} prevIndex The previous index of the tile. 1382 * @param {number} prevIndex The previous index of the tile.
1383 */ 1383 */
1384 tileMoved: function(draggedTile, prevIndex) { 1384 tileMoved: function(draggedTile, prevIndex) {
1385 }, 1385 },
1386 1386
1387 /** 1387 /**
1388 * Sets the drop effect on |dataTransfer| to the desired value (e.g. 1388 * Sets the drop effect on |dataTransfer| to the desired value (e.g.
1389 * 'copy'). 1389 * 'copy').
1390 * @param {Object} dataTransfer The drag event dataTransfer object. 1390 * @param {Object} dataTransfer The drag event dataTransfer object.
1391 */ 1391 */
1392 setDropEffect: function(dataTransfer) { 1392 setDropEffect: function(dataTransfer) {
1393 assert(false); 1393 assertNotReached();
1394 }, 1394 },
1395 }; 1395 };
1396 1396
1397 return { 1397 return {
1398 getCurrentlyDraggingTile: getCurrentlyDraggingTile, 1398 getCurrentlyDraggingTile: getCurrentlyDraggingTile,
1399 setCurrentDropEffect: setCurrentDropEffect, 1399 setCurrentDropEffect: setCurrentDropEffect,
1400 TilePage: TilePage, 1400 TilePage: TilePage,
1401 }; 1401 };
1402 }); 1402 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extension_error_overlay.js ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698