ui/webui/resources/js/template_data_externs.js - Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(275)

My Issues | Starred Open | Closed | All

Side by Side Diff: ui/webui/resources/js/template_data_externs.js

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: done for tonight Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« ui/webui/resources/js/local_strings.js ('K') | « ui/webui/resources/js/parse_html_subset.js ('k') | ui/webui/resources/js/util.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.mojo.bindings;	5 /**

	6 * @fileoverview Externs for \|templateData\| global.

	7 * @externs

	8 */

6	9

7 /**	10 /** @type {!Object\|undefined} */

8 * Base class for mojo generated interfaces.	11 window.templateData;
	arv (Not doing code reviews) 2014/07/24 16:44:24 can this be? var templateData; can this be? var templateData; Dan Beam 2014/07/25 01:52:33 it could've but I felt using `window.templateData` Show quoted text On 2014/07/24 16:44:24, arv wrote: > can this be? > > var templateData; it could've but I felt using `window.templateData` everywhere else was safer because it wouldn't cause a reference error if it's not defined (just `undefined`). is this desired? arv (Not doing code reviews) 2014/07/25 18:27:13 It seems like a ReferenceError might be able to ca Show quoted text On 2014/07/25 01:52:33, Dan Beam wrote: > On 2014/07/24 16:44:24, arv wrote: > > can this be? > > > > var templateData; > > it could've but I felt using `window.templateData` everywhere else was safer > because it wouldn't cause a reference error if it's not defined (just > `undefined`). is this desired? It seems like a ReferenceError might be able to catch errors in the code. Dan Beam 2014/07/25 21:58:18 very well, var templateData it is! :) Show quoted text On 2014/07/25 18:27:13, arv wrote: > On 2014/07/25 01:52:33, Dan Beam wrote: > > On 2014/07/24 16:44:24, arv wrote: > > > can this be? > > > > > > var templateData; > > > > it could've but I felt using `window.templateData` everywhere else was safer > > because it wouldn't cause a reference error if it's not defined (just > > `undefined`). is this desired? > > It seems like a ReferenceError might be able to catch errors in the code. very well, var templateData it is! :)
9 */

10 public interface Interface {

11

12 }

OLD	NEW

« ui/webui/resources/js/local_strings.js ('K') | « ui/webui/resources/js/parse_html_subset.js ('k') | ui/webui/resources/js/util.js » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698