Update browser tests to support upcoming EME parameter type changes.

Update browser tests to support upcoming EME parameter type changes.

The EME spec is now using ArrayBuffer/ArrayBufferView instead of
Uint8Array as the type for data buffers. Calls from JavaScript
aren't affected as Uint8Array is an ArrayBufferView. However,
"message" events now pass back an ArrayBuffer and the tests expect
Uint8Array. This converts the returned message to a Uint8Array
to keep the code working.

This change works with and without the upcoming changes. If
Uint8Array is passed back, then the result is that another copy of
the view is made.

BUG=358271
TEST=encrypted media browser_tests pass

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285672

[jrummell, 2014-07-18 23:23:39]

PTAL.

[ddorwin, 2014-07-20 22:35:06]

lgtm% comments

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/player_utils.js:46:
Utils.convertToUint8Array(message.message))) {
Hide this in iHBM()?

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/utils.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/utils.js:41: // this will just make a copy.
... of the view.
right?

Change the last sentence in the  description too.

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/utils.js:158: var initData =
Utils.convertToUint8Array(message.message);
This will probably need to change when we update Clear Key format, but it's good
that it's hidden

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/widevine_player.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/widevine_player.js:37:
Utils.convertToUint8Array(message.message),
I'm offline, so I can't see the rest. Does send request assume a ?Uint8Array? If
so, should it handle views too?

[jrummell, 2014-07-23 22:30:06]

Updated. PS2 is the changes, PS3 is the rebase now that the files have moved
directories.

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/player_utils.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/player_utils.js:46:
Utils.convertToUint8Array(message.message))) {
On 2014/07/20 22:35:05, ddorwin wrote:
> Hide this in iHBM()?

Done.

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/utils.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/utils.js:41: // this will just make a copy.
On 2014/07/20 22:35:05, ddorwin wrote:
> ... of the view.
> right?
> 
> Change the last sentence in the  description too.

Done.

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/utils.js:158: var initData =
Utils.convertToUint8Array(message.message);
On 2014/07/20 22:35:05, ddorwin wrote:
> This will probably need to change when we update Clear Key format, but it's
good
> that it's hidden

Acknowledged.

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
File chrome/test/data/media/eme_player_js/widevine_player.js (right):

https://codereview.chromium.org/405733003/diff/1/chrome/test/data/media/eme_p...
chrome/test/data/media/eme_player_js/widevine_player.js:37:
Utils.convertToUint8Array(message.message),
On 2014/07/20 22:35:05, ddorwin wrote:
> I'm offline, so I can't see the rest. Does send request assume a ?Uint8Array?
If
> so, should it handle views too?

According to https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest,
send() accepts an ArrayBufferView, but not an ArrayBuffer (no longer accepted).
Since the message event returns an ArrayBuffer, it needs to be converted.

[shadi, 2014-07-24 17:46:51]

LGTM % nit

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/utils.js (right):

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/utils.js:40: // Assume it is ArrayBuffer or
ArrayBufferView. If it already a Uint8Array,
s/a/is a

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/widevine_player.js (right):

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/widevine_player.js:37:
Utils.convertToUint8Array(message.message),
The prefixed_widevine_player.js is not affected right?

[jrummell, 2014-07-25 19:34:06]

Thanks for the reviews.

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/utils.js (right):

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/utils.js:40: // Assume it is ArrayBuffer or
ArrayBufferView. If it already a Uint8Array,
On 2014/07/24 17:46:51, shadi wrote:
> s/a/is a

Done.

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
File media/test/data/eme_player_js/widevine_player.js (right):

https://codereview.chromium.org/405733003/diff/40001/media/test/data/eme_play...
media/test/data/eme_player_js/widevine_player.js:37:
Utils.convertToUint8Array(message.message),
On 2014/07/24 17:46:51, shadi wrote:
> The prefixed_widevine_player.js is not affected right?

Correct. The prefixed code still returns a Uint8Array.

[jrummell, 2014-07-25 19:34:09]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-07-25 19:35:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jrummell@chromium.org/405733003/60001

[commit-bot: I haz the power, 2014-07-25 20:50:20]

Change committed as 285672