Revert of Make ninja display elapsed compile time by default.

Revert of Make ninja display elapsed compile time by default. (https://codereview.chromium.org/268833006/)

Reason for revert:
This made the build pages more noisy and happened to not be as useful as hoped in practice.

If someone wants to use this to debug something, please add it temporarily while you debug, and then remove it again when you're done.

Original issue's description:
> Make ninja display elapsed compile time by default.
> 
> This will help debug slow or hanging compiles.
> 
> BUG=none
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269042

r287547

[Nico, 2014-07-18 23:20:24]

Created Revert of Make ninja display elapsed compile time by default.

[commit-bot: I haz the power, 2014-07-18 23:20:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/405733002/1

[commit-bot: I haz the power, 2014-07-18 23:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 23:20:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[ghost stip (do not use), 2014-07-19 01:04:49]

surprised this didn't have a tbr. lgtm

[Paweł Hajdan Jr., 2014-07-23 10:54:10]

"and happened to not be as useful as hoped in practice"

This surprised me. I used it several times.

I'm not going to fight to preserve this. Next time anyone needs the data and
it's not there I'll just point to this CL.

One possible alternative is for ninja to expose the times in a JSON file.
However, to diagnose compiles that are timing out and killed that file would
need to be updated and flushed fairly often.

IMHO removing this needs a stronger justification and addressing my earlier and
present comments about why it's needed.

[Nico, 2014-07-23 15:40:01]

On 2014/07/23 10:54:10, Paweł Hajdan Jr. wrote:
> "and happened to not be as useful as hoped in practice"
> 
> This surprised me. I used it several times.

I'm surprised you're surprised. I asked you repeatedly for examples where you
used this and made decisions based on this data. You sent me links to a few bugs
that were opened a while ago and didn't see any progress.

> I'm not going to fight to preserve this. Next time anyone needs the data and
> it's not there I'll just point to this CL.

As I said, if someone needs this data to do something, they can enable this
temporarily to collect it. So far, I haven't seen any (!) examples where it got
used.

> One possible alternative is for ninja to expose the times in a JSON file.

https://github.com/nico/ninjatracing converts .ninja_log files to about:tracing
traces.

> However, to diagnose compiles that are timing out and killed that file would
> need to be updated and flushed fairly often.
> 
> IMHO removing this needs a stronger justification and addressing my earlier
and
> present comments about why it's needed.

I feel the same about adding it in the first place.

[Nico, 2014-08-05 15:40:56]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-08-05 15:41:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/405733002/1

[commit-bot: I haz the power, 2014-08-05 15:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 15:41:54]

Failed to apply patch for build/scripts/slave/compile.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/scripts/slave/compile.py
  Hunk #1 FAILED at 729.
  1 out of 1 hunk FAILED -- saving rejects to file
build/scripts/slave/compile.py.rej

Patch:       build/scripts/slave/compile.py
Index: scripts/slave/compile.py
diff --git build/scripts/slave/compile.py build/scripts/slave/compile.py
index
dc5d3b3e9791692fa6e595c5b957745e4f65c927..1331afa262fe0049077459578b7d4ad25acf7d37
100755
--- a/build/scripts/slave/compile.py
+++ b/build/scripts/slave/compile.py
@@ -729,7 +729,6 @@
 
   # Prepare environment.
   env = EchoDict(os.environ)
-  env.setdefault('NINJA_STATUS', '[%s/%t | %e] ')
   orig_compiler = options.compiler
   goma_ready = goma_setup(options, env)
   if not goma_ready:

[Nico, 2014-08-05 15:56:02]

(landed manually in r287547)

[jabdelmalek, 2014-08-18 19:12:32]

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/483853002/ by jabdelmalek@google.com.

The reason for reverting is: see discussion in
https://codereview.chromium.org/268833006/.