win: Do not add directories already in C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\INCLU…

win: Do not add directories already in %INCLUDE% to msvs_system_include_dirs.

clang-cl honors INCLUDE and treats it as system include directory,
but if the same directory is also included through -I that apparently
overwrites the system-ness. So don't add INCLUDE directories in gyp,
so that warnings in them aren't printed.

Should fix over 1900 -Wextern-initializer warnings on the clang/win bot.

Depends on a new toolchain package that's built with
https://codereview.chromium.org/393233004/ applied.
BUG=395405

[scottmg, 2014-07-18 23:06:36]

I think this is probably fine these days, these were mostly for VS-based-builds.
Or it might cause problems for Express, but there's no bot for that, so...

lgtm if it works-ish and it's helpful to land.

[Nico, 2014-07-18 23:10:06]

On 2014/07/18 23:06:36, scottmg wrote:
> I think this is probably fine these days, these were mostly for
VS-based-builds.
> Or it might cause problems for Express, but there's no bot for that, so...
> 
> lgtm if it works-ish and it's helpful to land.

http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...
thinks it doesn't work. On my system, I get a different %INCLUDE% depending on
the different methods to set up the build env that gyp tries :-/

[scottmg, 2014-07-18 23:31:54]

Darn. Yeah, it would appear I did not put 'winrt' into
depot_tools\win_toolchain\vs2013_files\win8sdk\bin\SetEnv.cmd.

[Nico, 2014-07-18 23:32:35]

On 2014/07/18 23:31:54, scottmg wrote:
> Darn. Yeah, it would appear I did not put 'winrt' into
> depot_tools\win_toolchain\vs2013_files\win8sdk\bin\SetEnv.cmd.

Can it just be added there?

[scottmg, 2014-07-18 23:40:52]

On 2014/07/18 23:32:35, Nico (away) wrote:
> On 2014/07/18 23:31:54, scottmg wrote:
> > Darn. Yeah, it would appear I did not put 'winrt' into
> > depot_tools\win_toolchain\vs2013_files\win8sdk\bin\SetEnv.cmd.
> 
> Can it just be added there?

Yes, it'll just require repackaging, updating the toolchain, and rolling new
hashes. Are you in a rush for this? We could make the change in the script
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/win_...
and then roll it out when vs2013 update3 has to be updated anyway (in RC now so
~some weeks)

[Nico, 2014-07-18 23:41:28]

On 2014/07/18 23:40:52, scottmg wrote:
> On 2014/07/18 23:32:35, Nico (away) wrote:
> > On 2014/07/18 23:31:54, scottmg wrote:
> > > Darn. Yeah, it would appear I did not put 'winrt' into
> > > depot_tools\win_toolchain\vs2013_files\win8sdk\bin\SetEnv.cmd.
> > 
> > Can it just be added there?
> 
> Yes, it'll just require repackaging, updating the toolchain, and rolling new
> hashes. Are you in a rush for this? We could make the change in the script
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/win_...
> and then roll it out when vs2013 update3 has to be updated anyway (in RC now
so
> ~some weeks)

No, no rush.

[Nico, 2014-07-18 23:46:09]

https://codereview.chromium.org/393233004/ adds it to the depot_tools script, I
think.