Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 405713003: Fix untrusted.gypi and build_nexe.py (Closed)

Created:
6 years, 5 months ago by Nick Bray (chromium)
Modified:
6 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix untrusted.gypi and build_nexe.py A prior version of this change was commited as r13485 and reverted as r13506. In the meantime, functionality was added to fix a bug where source files with the same name would overwrite eachother's object files. BUG=none R=bradnelson@google.com, dschuff@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M build/build_nexe.py View 6 chunks +16 lines, -11 lines 0 comments Download
M build/untrusted.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nick Bray (chromium)
6 years, 5 months ago (2014-07-18 22:47:34 UTC) #1
bradn
lgtm
6 years, 5 months ago (2014-07-18 22:54:32 UTC) #2
Derek Schuff
lgtm
6 years, 5 months ago (2014-07-18 23:07:28 UTC) #3
Nick Bray (chromium)
Committed patchset #1 manually as r13512 (presubmit successful).
6 years, 5 months ago (2014-07-21 17:32:59 UTC) #4
Mark Seaborn
6 years, 5 months ago (2014-07-25 16:45:17 UTC) #5
Message was sent while issue was closed.
When rolling DEPS, I see this compile failure:

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
icuuc_nacl_target_build_newlib_plib_ce70c0dab4349afb56b95a15e808ff16..rsp
..\..\third_party\icu
source/common/putil.cpp:638:12: error: 'timezone' does not refer to a value
    return U_TIMEZONE;
           ^
source/common/putilimp.h:135:23: note: expanded from macro 'U_TIMEZONE'
#   define U_TIMEZONE timezone
                      ^
E:/b/build/slave/win/build/src/out/Release/gen/sdk/win_x86/pnacl_newlib/usr/include\sys/time.h:41:8:
note: declared here
struct timezone {
       ^
1 error generated.
...
FAILED: Command
'..\..\out\Release\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang++ -c
source/common/putil.cpp -o
../../out/Release/obj/third_party/icu/icuuc_nacl.gen/pnacl_newlib-pnacl/icuuc_nacl/putil_a4b8bb19.o
...

(from
http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...
and https://codereview.chromium.org/422433003/)

Since this is in 'icu', and you had problems with 'icu', is this NaCl change the
cause?

Maybe you've made 'icu' changes in Chromium that LKGR hasn't caught up with?

Powered by Google App Engine
This is Rietveld 408576698