[refactor] Use base::CheckedNumeric<> in place of manual checks.

[refactor] Use base::CheckedNumeric<> in place of manual checks.

BUG=394821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284546

[Ryan Sleevi, 2014-07-18 22:56:05]

lgtm

[eroman, 2014-07-19 13:32:10]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-19 13:33:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/405693002/1

[commit-bot: I haz the power, 2014-07-19 16:46:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)

[commit-bot: I haz the power, 2014-07-19 16:50:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-19 16:50:56]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[eroman, 2014-07-21 15:32:47]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-21 15:33:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/405693002/20001

[eroman, 2014-07-21 17:53:49]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2014-07-21 17:57:19]

The CQ bit was checked by eroman@chromium.org

[eroman, 2014-07-21 17:57:34]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2014-07-21 18:12:42]

https://codereview.chromium.org/405693002/diff/60001/content/child/webcrypto/...
File content/child/webcrypto/openssl/aes_cbc_openssl.cc (right):

https://codereview.chromium.org/405693002/diff/60001/content/child/webcrypto/...
content/child/webcrypto/openssl/aes_cbc_openssl.cc:54:
base::CheckedNumeric<unsigned int> output_max_len = data.byte_length();
I have uploaded a new patchset which fixes a problem in this conversion
(template parameter should be an "int" not "unsigned int").

(Caught by unittests)

[eroman, 2014-07-21 18:12:53]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:14:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/405693002/80001

[commit-bot: I haz the power, 2014-07-21 20:14:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/35512)

[commit-bot: I haz the power, 2014-07-21 20:17:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 20:17:16]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)

[eroman, 2014-07-21 21:52:45]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-21 21:54:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/405693002/80001

[commit-bot: I haz the power, 2014-07-22 00:08:33]

Change committed as 284546