Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 405683003: Adds the UserMedia requests to the UI of chrome://webrtc-internals. (Closed)

Created:
6 years, 5 months ago by jiayl
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds the UserMedia requests to the UI of chrome://webrtc-internals. Also fix an issue with missing constriants logged at webrtc-internals. See a snapshot of the UI at https://docs.google.com/a/google.com/presentation/d/1dL2flqsQj8h_dTO9t8BWOCjiwbLiZCN2Nt93FHqpM9o/edit?usp=sharing BUG=304023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284545

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -9 lines) Patch
M content/browser/media/webrtc_internals_browsertest.cc View 2 chunks +19 lines, -1 line 0 comments Download
M content/browser/resources/media/tab_view.js View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/resources/media/webrtc_internals.css View 2 chunks +11 lines, -1 line 0 comments Download
M content/browser/resources/media/webrtc_internals.js View 1 5 chunks +46 lines, -3 lines 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 2 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
jiayl
vrk, Could you take a look?
6 years, 5 months ago (2014-07-18 21:48:42 UTC) #1
vrk (LEFT CHROMIUM)
lgtm https://codereview.chromium.org/405683003/diff/1/content/browser/resources/media/webrtc_internals.js File content/browser/resources/media/webrtc_internals.js (right): https://codereview.chromium.org/405683003/diff/1/content/browser/resources/media/webrtc_internals.js#newcode314 content/browser/resources/media/webrtc_internals.js:314: if (requests[i].rid == data.rid) { nit: no {} ...
6 years, 5 months ago (2014-07-18 22:01:06 UTC) #2
jiayl
https://codereview.chromium.org/405683003/diff/1/content/browser/resources/media/webrtc_internals.js File content/browser/resources/media/webrtc_internals.js (right): https://codereview.chromium.org/405683003/diff/1/content/browser/resources/media/webrtc_internals.js#newcode314 content/browser/resources/media/webrtc_internals.js:314: if (requests[i].rid == data.rid) { On 2014/07/18 22:01:06, Victoria ...
6 years, 5 months ago (2014-07-18 22:06:24 UTC) #3
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 5 months ago (2014-07-18 22:06:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/405683003/20001
6 years, 5 months ago (2014-07-18 22:08:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 01:51:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 02:12:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/53357) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/25843)
6 years, 5 months ago (2014-07-19 02:12:38 UTC) #8
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 5 months ago (2014-07-21 15:53:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/405683003/20001
6 years, 5 months ago (2014-07-21 15:53:54 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 17:27:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 17:47:00 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1045)
6 years, 5 months ago (2014-07-21 17:47:01 UTC) #13
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 5 months ago (2014-07-21 19:44:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/405683003/20001
6 years, 5 months ago (2014-07-21 19:48:32 UTC) #15
jiayl
The CQ bit was checked by jiayl@chromium.org
6 years, 5 months ago (2014-07-21 21:11:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/405683003/40001
6 years, 5 months ago (2014-07-21 21:12:53 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:07:37 UTC) #18
Message was sent while issue was closed.
Change committed as 284545

Powered by Google App Engine
This is Rietveld 408576698