Issue 405683002: ui: Remove some unnecessary functions from the API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405683002: ui: Remove some unnecessary functions from the API. (Closed)

Created:
6 years, 5 months ago by sadrul

Modified:
6 years, 5 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, nkostylev+watch_chromium.org, tdresser+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

ui: Remove some unnecessary functions from the API. . There is only X11 implementation of IsTouchpadEvent(), and it is used by DeviceUMA. But DeviceUMA also talks to DeviceDataManagerX11. So remove ui::IsTouchpadEvent(), and directly query DDMX11 whether the event is a touchpad event. . Remove SetNaturalScroll() and IsNaturalScrollEnabled() since nothing uses these anymore (and there are no implementations of these either). BUG=none R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284306

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -70 lines)			Patch
M	chrome/browser/chromeos/device_uma.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	ui/events/cocoa/events_mac.mm	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	ui/events/event_utils.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/events/events_stub.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	ui/events/ozone/events_ozone.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/events/win/events_win.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	ui/events/x/events_x.cc	View	2 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 5 months ago (2014-07-19 04:43:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r284306 (presubmit successful).

Expand Messages | Collapse Messages