Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: content/browser/media/android/media_resource_getter_impl.cc

Issue 405663002: Support basic authentication for html5 media (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updating crbug Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/media_resource_getter_impl.cc
diff --git a/content/browser/media/android/media_resource_getter_impl.cc b/content/browser/media/android/media_resource_getter_impl.cc
index f33c26d0bea3952997f94a46713f7a34c2a8172c..2f5d9689bd4fcfbe77cc4b22fef86e8d87eb2e36 100644
--- a/content/browser/media/android/media_resource_getter_impl.cc
+++ b/content/browser/media/android/media_resource_getter_impl.cc
@@ -18,8 +18,11 @@
#include "content/public/common/content_client.h"
#include "content/public/common/url_constants.h"
#include "jni/MediaResourceGetter_jni.h"
+#include "net/base/auth.h"
#include "net/cookies/cookie_monster.h"
#include "net/cookies/cookie_store.h"
+#include "net/http/http_auth.h"
+#include "net/http/http_transaction_factory.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
#include "url/gurl.h"
@@ -104,30 +107,34 @@ static void GetMediaMetadata(
Java_MediaMetadata_isSuccess(env, j_metadata.obj())));
}
-// The task object that retrieves cookie on the IO thread.
+// The task object that retrieves media resources on the IO thread.
// TODO(qinmin): refactor this class to make the code reusable by others as
// there are lots of duplicated functionalities elsewhere.
-class CookieGetterTask
- : public base::RefCountedThreadSafe<CookieGetterTask> {
+// http://crbug.com/395762.
+class MediaResourceGetterTask
+ : public base::RefCountedThreadSafe<MediaResourceGetterTask> {
public:
- CookieGetterTask(BrowserContext* browser_context,
- int render_process_id, int render_frame_id);
+ MediaResourceGetterTask(BrowserContext* browser_context,
+ int render_process_id, int render_frame_id);
- // Called by CookieGetterImpl to start getting cookies for a URL.
+ // Called by MediaResourceGetterImpl to start getting auth credentials.
+ net::AuthCredentials RequestAuthCredentials(const GURL& url) const;
+
+ // Called by MediaResourceGetterImpl to start getting cookies for a URL.
void RequestCookies(
const GURL& url, const GURL& first_party_for_cookies,
const media::MediaResourceGetter::GetCookieCB& callback);
private:
- friend class base::RefCountedThreadSafe<CookieGetterTask>;
- virtual ~CookieGetterTask();
+ friend class base::RefCountedThreadSafe<MediaResourceGetterTask>;
+ virtual ~MediaResourceGetterTask();
void CheckPolicyForCookies(
const GURL& url, const GURL& first_party_for_cookies,
const media::MediaResourceGetter::GetCookieCB& callback,
const net::CookieList& cookie_list);
- // Context getter used to get the CookieStore.
+ // Context getter used to get the CookieStore and auth cache.
net::URLRequestContextGetter* context_getter_;
// Resource context for checking cookie policies.
@@ -139,10 +146,10 @@ class CookieGetterTask
// Render frame id, used to check tab specific cookie policy.
int render_frame_id_;
- DISALLOW_COPY_AND_ASSIGN(CookieGetterTask);
+ DISALLOW_COPY_AND_ASSIGN(MediaResourceGetterTask);
};
-CookieGetterTask::CookieGetterTask(
+MediaResourceGetterTask::MediaResourceGetterTask(
BrowserContext* browser_context, int render_process_id, int render_frame_id)
: context_getter_(browser_context->GetRequestContext()),
resource_context_(browser_context->GetResourceContext()),
@@ -150,9 +157,32 @@ CookieGetterTask::CookieGetterTask(
render_frame_id_(render_frame_id) {
}
-CookieGetterTask::~CookieGetterTask() {}
+MediaResourceGetterTask::~MediaResourceGetterTask() {}
-void CookieGetterTask::RequestCookies(
+net::AuthCredentials MediaResourceGetterTask::RequestAuthCredentials(
+ const GURL& url) const {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ net::HttpTransactionFactory* factory =
+ context_getter_->GetURLRequestContext()->http_transaction_factory();
+ if (!factory)
+ return net::AuthCredentials();
+
+ net::HttpAuthCache* auth_cache =
+ factory->GetSession()->http_auth_cache();
+ if (!auth_cache)
+ return net::AuthCredentials();
+
+ net::HttpAuthCache::Entry* entry =
+ auth_cache->LookupByPath(url.GetOrigin(), url.path());
+
+ // TODO(qinmin): handle other auth schemes. See http://crbug.com/395219.
+ if (entry && entry->scheme() == net::HttpAuth::AUTH_SCHEME_BASIC)
+ return entry->credentials();
+ else
+ return net::AuthCredentials();
+}
+
+void MediaResourceGetterTask::RequestCookies(
const GURL& url, const GURL& first_party_for_cookies,
const media::MediaResourceGetter::GetCookieCB& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
@@ -173,14 +203,14 @@ void CookieGetterTask::RequestCookies(
net::CookieMonster* cookie_monster = cookie_store->GetCookieMonster();
if (cookie_monster) {
cookie_monster->GetAllCookiesForURLAsync(url, base::Bind(
- &CookieGetterTask::CheckPolicyForCookies, this,
+ &MediaResourceGetterTask::CheckPolicyForCookies, this,
url, first_party_for_cookies, callback));
} else {
callback.Run(std::string());
}
}
-void CookieGetterTask::CheckPolicyForCookies(
+void MediaResourceGetterTask::CheckPolicyForCookies(
const GURL& url, const GURL& first_party_for_cookies,
const media::MediaResourceGetter::GetCookieCB& callback,
const net::CookieList& cookie_list) {
@@ -211,11 +241,25 @@ MediaResourceGetterImpl::MediaResourceGetterImpl(
MediaResourceGetterImpl::~MediaResourceGetterImpl() {}
+void MediaResourceGetterImpl::GetAuthCredentials(
+ const GURL& url, const GetAuthCredentialsCB& callback) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ scoped_refptr<MediaResourceGetterTask> task = new MediaResourceGetterTask(
+ browser_context_, 0, 0);
+
+ BrowserThread::PostTaskAndReplyWithResult(
+ BrowserThread::IO,
+ FROM_HERE,
+ base::Bind(&MediaResourceGetterTask::RequestAuthCredentials, task, url),
+ base::Bind(&MediaResourceGetterImpl::GetAuthCredentialsCallback,
+ weak_factory_.GetWeakPtr(), callback));
+}
+
void MediaResourceGetterImpl::GetCookies(
const GURL& url, const GURL& first_party_for_cookies,
const GetCookieCB& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- scoped_refptr<CookieGetterTask> task = new CookieGetterTask(
+ scoped_refptr<MediaResourceGetterTask> task = new MediaResourceGetterTask(
browser_context_, render_process_id_, render_frame_id_);
GetCookieCB cb = base::Bind(&MediaResourceGetterImpl::GetCookiesCallback,
@@ -224,11 +268,18 @@ void MediaResourceGetterImpl::GetCookies(
BrowserThread::PostTask(
BrowserThread::IO,
FROM_HERE,
- base::Bind(&CookieGetterTask::RequestCookies,
+ base::Bind(&MediaResourceGetterTask::RequestCookies,
task, url, first_party_for_cookies,
base::Bind(&ReturnResultOnUIThread, cb)));
}
+void MediaResourceGetterImpl::GetAuthCredentialsCallback(
+ const GetAuthCredentialsCB& callback,
+ const net::AuthCredentials& credentials) {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ callback.Run(credentials.username(), credentials.password());
+}
+
void MediaResourceGetterImpl::GetCookiesCallback(
const GetCookieCB& callback, const std::string& cookies) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
« no previous file with comments | « content/browser/media/android/media_resource_getter_impl.h ('k') | content/renderer/media/android/webmediaplayer_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698