Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 405653005: Fixing consistency of permissions warning strings. (Closed)

Created:
6 years, 5 months ago by mhm
Modified:
6 years, 5 months ago
Reviewers:
felt
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, jww, meacer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing consistency of permissions warning strings. Fixing some of the strings that are used for permissions warnings to ensure their consistency. BUG=362794 R=felt Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284555

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removing browser's word from strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mhm
Hey felt@ can you look at this for me to fix the consistency with warning ...
6 years, 5 months ago (2014-07-18 22:49:34 UTC) #1
felt
https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd#newcode287 extensions/extensions_strings.grd:287: Change your browser's home page to: <ph name="HOME_PAGE">$1<ex>home.page.com/home.html</ex></ph> Do ...
6 years, 5 months ago (2014-07-18 23:32:47 UTC) #2
mhm
Let me know what do you think felt@ https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd#newcode287 extensions/extensions_strings.grd:287: Change ...
6 years, 5 months ago (2014-07-19 00:07:30 UTC) #3
felt
https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd File extensions/extensions_strings.grd (right): https://codereview.chromium.org/405653005/diff/1/extensions/extensions_strings.grd#newcode287 extensions/extensions_strings.grd:287: Change your browser's home page to: <ph name="HOME_PAGE">$1<ex>home.page.com/home.html</ex></ph> On ...
6 years, 5 months ago (2014-07-19 00:26:24 UTC) #4
mhm
felt@ they are now consistent without the word "browser's".
6 years, 5 months ago (2014-07-21 18:23:17 UTC) #5
felt
lgtm
6 years, 5 months ago (2014-07-21 18:51:18 UTC) #6
mhm
The CQ bit was checked by mohammed@chromium.org
6 years, 5 months ago (2014-07-21 19:07:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/405653005/20001
6 years, 5 months ago (2014-07-21 19:09:44 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:18:42 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:26:50 UTC) #10
Message was sent while issue was closed.
Change committed as 284555

Powered by Google App Engine
This is Rietveld 408576698