slave/skia_slave_scripts/build_step.py - Issue 405653004: add ACL-setting code to upload_rendered_skps.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/build_step.py

Issue 405653004: add ACL-setting code to upload_rendered_skps.py (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: created local gs_utils wrapper module Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: slave/skia_slave_scripts/build_step.py

diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py

index 9a821de5b0b1112d13de5dbe897f959338377eb5..fb199224f5df108afd6610b5a7aecea1cec55052 100644

--- a/slave/skia_slave_scripts/build_step.py

+++ b/slave/skia_slave_scripts/build_step.py

@@ -51,10 +51,6 @@ INT_FALSE = 0

build_step_stdout_has_written = multiprocessing.Value('i', INT_FALSE)

-# The canned acl to use while copying playback files to Google Storage.

-PLAYBACK_CANNED_ACL = 'private'

class BuildStepWarning(Exception):

pass