mojo/gles2/command_buffer_client_impl.cc - Issue 405653003: mojo: Make InterfacePtr<> testable in if() statements without .get().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/gles2/command_buffer_client_impl.cc

Issue 405653003: mojo: Make InterfacePtr<> testable in if() statements without .get(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move to is_bound() Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/gles2/command_buffer_client_impl.cc

diff --git a/mojo/gles2/command_buffer_client_impl.cc b/mojo/gles2/command_buffer_client_impl.cc

index 1a03468e4aaa7b9c9dcab506b99836432c00e464..3a716970821c3f87a77c413f1a051b222a1616c5 100644

--- a/mojo/gles2/command_buffer_client_impl.cc

+++ b/mojo/gles2/command_buffer_client_impl.cc

@@ -288,7 +288,7 @@ void CommandBufferClientImpl::MakeProgressAndUpdateState() {

command_buffer_->MakeProgress(last_state_.get_offset);

CommandBufferStatePtr state = sync_client_impl_->WaitForProgress();

- if (!state.get()) {

+ if (!state) {

VLOG(1) << "Channel encountered error while waiting for command buffer";

// TODO(piman): is it ok for this to re-enter?

DidDestroy();