Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: mojo/services/gles2/command_buffer_impl.cc

Issue 405653003: mojo: Make InterfacePtr<> testable in if() statements without .get(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to ToT Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/gles2/command_buffer_impl.cc
diff --git a/mojo/services/gles2/command_buffer_impl.cc b/mojo/services/gles2/command_buffer_impl.cc
index 4b836d88b538bb18d21567401c196f633d934f92..1f40444012d5855a0b69eb4e110c8ecc1d47ee4d 100644
--- a/mojo/services/gles2/command_buffer_impl.cc
+++ b/mojo/services/gles2/command_buffer_impl.cc
@@ -52,7 +52,7 @@ CommandBufferImpl::CommandBufferImpl(gfx::AcceleratedWidget widget,
CommandBufferImpl::~CommandBufferImpl() {
client()->DidDestroy();
- if (decoder_.get()) {
+ if (decoder_) {
bool have_context = decoder_->MakeCurrent();
decoder_->Destroy(have_context);
}
@@ -130,7 +130,7 @@ bool CommandBufferImpl::DoInitialize(
const size_t kSize = sizeof(gpu::CommandBufferSharedState);
scoped_ptr<gpu::BufferBacking> backing(
gles2::MojoBufferBacking::Create(shared_state.Pass(), kSize));
- if (!backing.get())
+ if (!backing)
return false;
command_buffer_->SetSharedStateBuffer(backing.Pass());
@@ -159,7 +159,7 @@ void CommandBufferImpl::RegisterTransferBuffer(
// This validates the size.
scoped_ptr<gpu::BufferBacking> backing(
gles2::MojoBufferBacking::Create(transfer_buffer.Pass(), size));
- if (!backing.get()) {
+ if (!backing) {
DVLOG(0) << "Failed to map shared memory.";
return;
}

Powered by Google App Engine
This is Rietveld 408576698