Issue 405643002: Blacklist for UBsan's vptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405643002: Blacklist for UBsan's vptr. (Closed)

Created:
6 years, 5 months ago by byoungyoung

Modified:
6 years, 5 months ago

Reviewers:
Alexander Potapenko, samsonov, aarya

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Blacklist for UBsan's vptr. To avoid false-positive reports from UBsan's vptr instrumented Chrome, sources/functions/types are blacklisted. The reasons for each blacklisting is accordingly commented. BUG=174801 R=aarya@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285353

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -0 lines)			Patch
	A	tools/ubsan_vptr/blacklist.txt	View	1	1 chunk	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aarya

lgtm https://codereview.chromium.org/405643002/diff/1/tools/ubsan_vptr/blacklist.txt File tools/ubsan_vptr/blacklist.txt (right): https://codereview.chromium.org/405643002/diff/1/tools/ubsan_vptr/blacklist.txt#newcode71 tools/ubsan_vptr/blacklist.txt:71: # avoid linke errors; e.g., undefined reference to ...

6 years, 5 months ago (2014-07-18 17:25:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byoungyoung@chromium.org/405643002/20001

6 years, 5 months ago (2014-07-24 15:00:25 UTC) #3

Message was sent while issue was closed.

Change committed as 285353

Expand Messages | Collapse Messages