Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 405623003: Add prefs for collapsed currently open tabs group in new tab page (Closed)

Created:
6 years, 5 months ago by Yusuf
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add prefs for collapsed currently open tabs group in new tab page BUG=389697 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284309

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed javadoc for all calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java View 1 2 chunks +45 lines, -18 lines 0 comments Download
M chrome/browser/android/new_tab_page_prefs.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/new_tab_page_prefs.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuf
6 years, 5 months ago (2014-07-18 15:01:49 UTC) #1
David Trainor- moved to gerrit
lgtm style/general code lgtm. not sure what this is for though!
6 years, 5 months ago (2014-07-18 16:52:28 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/405623003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java File chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java (right): https://codereview.chromium.org/405623003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java#newcode34 chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java:34: * Set currently open tabs list collapsed or ...
6 years, 5 months ago (2014-07-18 18:41:13 UTC) #3
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 5 months ago (2014-07-18 22:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/405623003/20001
6 years, 5 months ago (2014-07-18 22:56:50 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 04:50:00 UTC) #6
Message was sent while issue was closed.
Change committed as 284309

Powered by Google App Engine
This is Rietveld 408576698