Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 405583002: DevTools: get rid of obsolete "Sources Panel" section in shortcuts screen (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: get rid of obsolete "Sources Panel" section in shortcuts screen Sources Panel triggered creation of "Sources Panel" section in shortcuts panel. The variable haven't being used anywhere in the code, and we don't have a "Sources Panel" any more, thus its safe to remove it. R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
lushnikov
ptal
6 years, 5 months ago (2014-07-18 08:50:09 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-18 08:50:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/405583002/1
6 years, 5 months ago (2014-07-18 08:51:37 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 09:57:01 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 10:57:38 UTC) #5
Message was sent while issue was closed.
Change committed as 178430

Powered by Google App Engine
This is Rietveld 408576698