Issue 405563003: DevTools: Do not add stack traces twice on nested events in timeline

Issue 405563003: DevTools: Do not add stack traces twice on nested events in timeline (Closed)

Created:
6 years, 5 months ago by alph

Modified:
6 years, 5 months ago

Reviewers:
yurys, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Do not add stack traces twice on nested events in timeline BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178434

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment, #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	1	4 chunks	+18 lines, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yurys

https://codereview.chromium.org/405563003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/405563003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode637 Source/devtools/front_end/timeline/TimelineFlameChart.js:637: return event.stackTrace ? event.stackTrace.length - jsStackHeight : 0; You ...

6 years, 5 months ago (2014-07-18 11:16:20 UTC) #2

alph

ptal https://codereview.chromium.org/405563003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js File Source/devtools/front_end/timeline/TimelineFlameChart.js (right): https://codereview.chromium.org/405563003/diff/1/Source/devtools/front_end/timeline/TimelineFlameChart.js#newcode637 Source/devtools/front_end/timeline/TimelineFlameChart.js:637: return event.stackTrace ? event.stackTrace.length - jsStackHeight : 0; ...

6 years, 5 months ago (2014-07-18 11:21:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/405563003/20001

6 years, 5 months ago (2014-07-18 11:36:42 UTC) #6

Message was sent while issue was closed.

Change committed as 178434

Expand Messages | Collapse Messages