Issue 405563002: Remove redundant forward declaration and header inclusion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405563002: Remove redundant forward declaration and header inclusion. (Closed)

Created:
6 years, 5 months ago by byungwoo

Modified:
6 years, 5 months ago

Reviewers:
Inactive, rwlbuis

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove redundant forward declaration and header inclusions. Remove forward declaration from HTMLStyleElement.h - StyleSheet Remove header inclusions from HTMLStyleElement.cpp - ContextFeatures.h, StyleEngine.h, StyleSheetContents.h NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178552

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	Source/core/html/HTMLStyleElement.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/html/HTMLStyleElement.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

byungwoo

I removed redundant header inclusions and forward declaration. Please review this.

6 years, 5 months ago (2014-07-18 22:21:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bw80.lee@samsung.com/405563002/1

6 years, 5 months ago (2014-07-21 12:08:46 UTC) #3

Message was sent while issue was closed.

Change committed as 178552

Expand Messages | Collapse Messages