mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc - Issue 405523002: Add ability APIs for opening a window with a url embedded, focusing and activating a window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

Issue 405523002: Add ability APIs for opening a window with a url embedded, focusing and activating a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/mojo_services.gypi ('k') | mojo/services/public/interfaces/window_manager/window_manager.mojom » ('j') | mojo/services/window_manager/window_manager_app.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

index 4a69ff099884366632244f94937028abac2a5b31..2d3233a1570d1887d19bb7c522d38660ef40ce70 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

@@ -547,7 +547,6 @@ ViewManagerClientImpl::ViewManagerClientImpl(ApplicationConnection* connection,

dispatcher_(NULL) {}

ViewManagerClientImpl::~ViewManagerClientImpl() {

- delegate_->OnViewManagerDisconnected(this);

while (!nodes_.empty()) {

IdToNodeMap::iterator it = nodes_.begin();

if (OwnsNode(it->second->id()))

@@ -562,6 +561,7 @@ ViewManagerClientImpl::~ViewManagerClientImpl() {

else

views_.erase(it);

}

+ delegate_->OnViewManagerDisconnected(this);

}

Id ViewManagerClientImpl::CreateNode() {