Add ability APIs for opening a window with a url embedded, focusing and activating a window.

Add ability APIs for opening a window with a url embedded, focusing and activating a window.

R=sky@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284246

[sky, 2014-07-17 23:15:43]

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
File mojo/services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:74:
WindowManagerApp::~WindowManagerApp() {}
Do you need to delete windows in node_id_to_window_map_ here?

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:88: root_->AddChild(node);
Are you guaranteed to have a root_ by the time you get this?

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:143:
root_->AddObserver(this);
Do you need to remove this in the destructor if non-null?

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:156:
focus_client_->AddObserver(this);
Remove these observers?

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:201: }
Do you need to UnregisterSubstree here? If not, who cleans up
node_id_to_window_map_?

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:261: aura::Window* window =
it->second;
put in scoped_ptr so you don't need delete on 266.

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
File mojo/services/window_manager/window_manager_app.h (right):

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.h:92: void
RegisterSubtree(view_manager::Id id, aura::Window* parent);
Add descriptions.

[Ben Goodger (Google), 2014-07-18 19:50:44]

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
File mojo/services/window_manager/window_manager_app.cc (right):

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:88: root_->AddChild(node);
On 2014/07/17 23:15:42, sky wrote:
> Are you guaranteed to have a root_ by the time you get this?

No. In practice the test waits for IsReady(), but I don't actually block these
calls. I've changed these methods to return failure thru the callback.

https://codereview.chromium.org/405523002/diff/20001/mojo/services/window_man...
mojo/services/window_manager/window_manager_app.cc:201: }
On 2014/07/17 23:15:42, sky wrote:
> Do you need to UnregisterSubstree here? If not, who cleans up
> node_id_to_window_map_?

I removed this method. It's actually never called for this app as the view
manager doesn't destroy the root node until after it is disconnected from the
app embedded at it.

The windows that live in the node id to window map are freed in the dtor now.

[sky, 2014-07-18 20:06:09]

LGTM

[Ben Goodger (Google), 2014-07-18 23:17:31]

Committed patchset #5 manually as r284246 (presubmit successful).