Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 405503002: Revert 283813 "Switch to BoringSSL." (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 5 months ago
Reviewers:
agl
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 283813 "Switch to BoringSSL." Failed WebRtcBrowserTest on android_dbg_triggered_tests. > Switch to BoringSSL. > > (This is a reland of r283542 which was reverted in r283591 because it > broke the WebView build. The android_aosp trybots are broken[1] so this > based on hope.) > > This is a much larger change than its diff suggests. If it breaks > something, please revert first and ask questions later. > > [1] http://code.google.com/p/chromium/issues/detail?id=394597 > > BUG=none > > Review URL: https://codereview.chromium.org/399993002 TBR=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+747 lines, -513 lines) Patch
M trunk/src/DEPS View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/android_webview/buildbot/deps_whitelist.py View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/android_webview/native/webview_native.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/build/linux/unbundle/replace_gyp_files.py View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/webcrypto/platform_crypto_openssl.cc View 3 chunks +23 lines, -24 lines 0 comments Download
M trunk/src/content/content_child.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/crypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/crypto/crypto.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/crypto/crypto_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/crypto/encryptor_openssl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/crypto/openssl_bio_string_unittest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M trunk/src/crypto/openssl_util.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/crypto/rsa_private_key_openssl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/crypto/scoped_openssl_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/crypto/signature_verifier_openssl.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M trunk/src/google_apis/google_apis.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/BUILD.gn View 6 chunks +9 lines, -5 lines 0 comments Download
M trunk/src/net/android/keystore_openssl.cc View 13 chunks +452 lines, -260 lines 0 comments Download
M trunk/src/net/android/keystore_unittest.cc View 5 chunks +156 lines, -1 line 0 comments Download
M trunk/src/net/cert/cert_verify_proc_openssl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/cert/x509_certificate_openssl.cc View 4 chunks +17 lines, -10 lines 0 comments Download
M trunk/src/net/http/des.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/net/net.gyp View 8 chunks +12 lines, -7 lines 0 comments Download
M trunk/src/net/net_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/quic/crypto/aead_base_decrypter_openssl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M trunk/src/net/quic/crypto/aead_base_encrypter_openssl.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M trunk/src/net/socket/openssl_ssl_util.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_openssl.cc View 10 chunks +12 lines, -11 lines 0 comments Download
M trunk/src/net/socket/ssl_server_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/socket/ssl_session_cache_openssl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/tools/flip_server/acceptor_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/tools/flip_server/spdy_ssl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/remoting/host/token_validator_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/remoting/remoting_nacl.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
D trunk/src/third_party/boringssl/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
D trunk/src/third_party/boringssl/boringssl_nacl.gyp View 1 chunk +0 lines, -50 lines 0 comments Download
M trunk/src/third_party/libjingle/libjingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/third_party/libjingle/libjingle_nacl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/third_party/usrsctp/usrsctp.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-17 20:06:41 UTC) #1
Vitaly Buka (NO REVIEWS)
Committed patchset #1 manually as r283845 (tree was closed).
6 years, 5 months ago (2014-07-17 20:07:11 UTC) #2
agl
6 years, 5 months ago (2014-07-17 20:16:27 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698