Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 405483004: Fixes for wifi side of GCD prototype (Closed)

Created:
6 years, 5 months ago by Noam Samuel
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fixes for wifi side of GCD prototype 1. Moved actual device indicator to config.json 2. Wireless interface now part of config.json 3. LED path now part of config.json 4. udhcpd config now generated by script This should make the script a fair bit more robust and allow it to work on any machine. In addition, updated the SSID to the new format. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284171

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -52 lines) Patch
M components/cloud_devices/tools/prototype/prototype.py View 1 16 chunks +108 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Noam Samuel
6 years, 5 months ago (2014-07-17 23:07:31 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode26 components/cloud_devices/tools/prototype/prototype.py:26: import random order https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode456 components/cloud_devices/tools/prototype/prototype.py:456: 'txtvers=2', I guess ...
6 years, 5 months ago (2014-07-18 18:45:39 UTC) #2
Noam Samuel
https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode456 components/cloud_devices/tools/prototype/prototype.py:456: 'txtvers=2', On 2014/07/18 18:45:38, Vitaly Buka wrote: > I ...
6 years, 5 months ago (2014-07-18 18:48:08 UTC) #3
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 5 months ago (2014-07-18 18:51:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/405483004/20001
6 years, 5 months ago (2014-07-18 18:53:17 UTC) #5
commit-bot: I haz the power
Change committed as 284171
6 years, 5 months ago (2014-07-18 18:55:07 UTC) #6
Noam Samuel
6 years, 5 months ago (2014-07-18 20:26:39 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/too...
File components/cloud_devices/tools/prototype/prototype.py (right):

https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/too...
components/cloud_devices/tools/prototype/prototype.py:26: import random
On 2014/07/18 18:45:38, Vitaly Buka wrote:
> order

Done.

https://codereview.chromium.org/405483004/diff/1/components/cloud_devices/too...
components/cloud_devices/tools/prototype/prototype.py:456: 'txtvers=2',
On 2014/07/18 18:45:38, Vitaly Buka wrote:
> I guess we are going to use 3

Done.

Powered by Google App Engine
This is Rietveld 408576698