Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 405483003: Respect device ids in handling requests from extensions (Closed)

Created:
6 years, 5 months ago by vrk (LEFT CHROMIUM)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, tommi (sloooow) - chröme, bemasc
Project:
chromium
Visibility:
Public.

Description

Respect device ids in handling requests from extensions The extension code was hardcoded to use the default audio and video devices. This change actually respects the requested ids (if given). BUG=388428 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 chunk +42 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vrk (LEFT CHROMIUM)
Shijing: Note the TODO - didn't do the cleanup in this CL because I want ...
6 years, 5 months ago (2014-07-17 20:57:34 UTC) #1
no longer working on chromium
On 2014/07/17 20:57:34, Victoria Kirst wrote: > Shijing: Note the TODO - didn't do the ...
6 years, 5 months ago (2014-07-18 12:08:00 UTC) #2
vrk (LEFT CHROMIUM)
The CQ bit was checked by vrk@chromium.org
6 years, 5 months ago (2014-07-18 16:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/405483003/1
6 years, 5 months ago (2014-07-18 16:58:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 20:29:19 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:44:57 UTC) #6
Message was sent while issue was closed.
Change committed as 284233

Powered by Google App Engine
This is Rietveld 408576698