Only track profile inactivity for non-mobile platforms.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 50 matching lines @@
       // values (kMinutesInProfileValidDuration > 40,000).
       UMA_HISTOGRAM_CUSTOM_COUNTS("Profile.LockedProfilesDuration",
                                   time_since_lock.InMinutes(),
                                   1,
                                   kMinutesInProfileValidDuration,
                                   100);
     }
   }
 }
 
+bool HasProfileAtIndexBeenActiveSince(const ProfileInfoCache& info_cache,
+                                      int index,
+                                      const base::Time& active_limit) {
+  if (info_cache.GetProfileActiveTimeAtIndex(index) < active_limit) {

[bcwhite, 2014/07/18 16:38:44]

Can the entire condition test be moved inside the #ifdef?

[Mike Lerman, 2014/07/18 17:44:52]

You can! Done.

+// TODO(mlerman): iOS and Android should set an ActiveTime in the

[bcwhite, 2014/07/18 16:38:44]

Put the comment inside the appropriate #ifdef and indent to match code.

[Mike Lerman, 2014/07/18 17:44:52]

Acknowledged.

+// ProfileInfoCache. (see ProfileManager::OnBrowserSetLastActive)
+#if defined(OS_ANDROID) || defined(OS_IOS)
+    return true;
+#else
+    return false;
+#endif
+  }
+  return true;
+}
+
 }  // namespace
 
 enum ProfileAvatar {
   AVATAR_GENERIC = 0,       // The names for avatar icons
   AVATAR_GENERIC_AQUA,
   AVATAR_GENERIC_BLUE,
   AVATAR_GENERIC_GREEN,
   AVATAR_GENERIC_ORANGE,
   AVATAR_GENERIC_PURPLE,
   AVATAR_GENERIC_RED,
@@ skipping 30 matching lines @@
 
   // Ignore other metrics if we have no profiles, e.g. in Chrome Frame tests.
   if (!number_of_profiles)
     return false;
 
   // Maximum age for "active" profile is 4 weeks.
   base::Time oldest = base::Time::Now() -
       base::TimeDelta::FromDays(kMaximumDaysOfDisuse);
 
   for (size_t i = 0; i < number_of_profiles; ++i) {
-    if (info_cache.GetProfileActiveTimeAtIndex(i) < oldest) {
+    if (HasProfileAtIndexBeenActiveSince(info_cache, i, oldest)) {
       counts->unused++;
     } else {
       if (info_cache.ProfileIsSupervisedAtIndex(i))
         counts->supervised++;
       if (!info_cache.GetUserNameOfProfileAtIndex(i).empty()) {
         counts->signedin++;
         if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
           counts->gaia_icon++;
       }
     }
@@ skipping 289 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }