Only track profile inactivity for non-mobile platforms.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 95 matching lines @@
 bool ProfileMetrics::CountProfileInformation(ProfileManager* manager,
                                              ProfileCounts* counts) {
   const ProfileInfoCache& info_cache = manager->GetProfileInfoCache();
   size_t number_of_profiles = info_cache.GetNumberOfProfiles();
   counts->total = number_of_profiles;
 
   // Ignore other metrics if we have no profiles, e.g. in Chrome Frame tests.
   if (!number_of_profiles)
     return false;
 
-  // Maximum age for "active" profile is 4 weeks.
-  base::Time oldest = base::Time::Now() -
-      base::TimeDelta::FromDays(kMaximumDaysOfDisuse);
+
 
   for (size_t i = 0; i < number_of_profiles; ++i) {
+// IOS and ANDROID never set an ActiveTime in the ProfileManager.
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+    // Maximum age for "active" profile is 4 weeks.
+    base::Time oldest = base::Time::Now() -

[bcwhite, 2014/07/18 01:13:59]

This is now calculating this value for every profile instead of just once at the
top.  May have to have another ifdef above.

+        base::TimeDelta::FromDays(kMaximumDaysOfDisuse);
+
     if (info_cache.GetProfileActiveTimeAtIndex(i) < oldest) {

[bcwhite, 2014/07/18 01:13:59]

I think the better choice would be to set the active time for these other OS.

       counts->unused++;
     } else {
+#else
+    {

[bcwhite, 2014/07/18 01:13:59]

This duplicate open brace will break editors' auto-brace-matching; they don't
recognize the ifdef.

+#endif
       if (info_cache.ProfileIsSupervisedAtIndex(i))
         counts->supervised++;
       if (!info_cache.GetUserNameOfProfileAtIndex(i).empty()) {
         counts->signedin++;
         if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
           counts->gaia_icon++;
       }
     }
   }
   return true;
@@ skipping 287 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }