Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 405453002: [oilpan]: Don't assert the context is destroyed _after_ the NewWebSocketChannelImpl in oilpan. (Closed)

Created:
6 years, 5 months ago by wibling-chromium
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

[oilpan]: Don't assert the context is destroyed _after_ the NewWebSocketChannelImpl in oilpan. This should fix a couple of the crashes we are seeing in the debug oilpan builds for websockets. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, tyoshino@chromium.org, vegorov@chromium.org, yhirano@chromium.org, zerny@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178379

Patch Set 1 #

Total comments: 2

Patch Set 2 : moved comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wibling-chromium
6 years, 5 months ago (2014-07-17 13:20:25 UTC) #1
Mads Ager (chromium)
LGTM, but Haraken should have a look as well.
6 years, 5 months ago (2014-07-17 13:36:47 UTC) #2
sof
https://codereview.chromium.org/405453002/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.h File Source/modules/websockets/NewWebSocketChannelImpl.h (left): https://codereview.chromium.org/405453002/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.h#oldcode152 Source/modules/websockets/NewWebSocketChannelImpl.h:152: // This object must be destroyed before the context. ...
6 years, 5 months ago (2014-07-17 13:39:30 UTC) #3
wibling-chromium
Thanks for the reviews! I have updated the diff. https://codereview.chromium.org/405453002/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.h File Source/modules/websockets/NewWebSocketChannelImpl.h (left): https://codereview.chromium.org/405453002/diff/1/Source/modules/websockets/NewWebSocketChannelImpl.h#oldcode152 Source/modules/websockets/NewWebSocketChannelImpl.h:152: ...
6 years, 5 months ago (2014-07-17 14:16:49 UTC) #4
haraken
Thanks for the fix, LGTM.
6 years, 5 months ago (2014-07-17 14:35:45 UTC) #5
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 5 months ago (2014-07-17 14:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/405453002/20001
6 years, 5 months ago (2014-07-17 14:47:02 UTC) #7
commit-bot: I haz the power
Change committed as 178379
6 years, 5 months ago (2014-07-17 15:50:47 UTC) #8
tyoshino (SeeGerritForStatus)
6 years, 5 months ago (2014-07-18 12:00:08 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698