Issue 405433011: LeakDetector: Add commandline option to force crash when leak is found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405433011: LeakDetector: Add commandline option to force crash when leak is found. (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)

Modified:
6 years, 5 months ago

Reviewers:
haraken, hajimehoshi, jochen (gone - plz use gerrit)

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

LeakDetector: Add commandline option to force crash when leak is found. This CL modifies the LeakDetector to force immediate crash when an optional commandline argument is specified to content_shell. Usage: $ content_shell --dump-render-tree --enable-leak-detection=crash-on-failure This enables us to use the ClusterFuzz infrastructure to investigate and minimize leaks, as the tool currently detects the test case pass/fail by seeing if the process crashes. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284064

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	content/shell/browser/shell_content_browser_client.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	content/shell/browser/webkit_test_controller.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/browser/webkit_test_controller.cc	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	content/shell/common/shell_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/common/shell_switches.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/405433011/1

6 years, 5 months ago (2014-07-18 09:58:33 UTC) #4

kouhei (in TOK)

On 2014/07/18 09:12:06, jochen wrote: > lgtm Thanks for review!

6 years, 5 months ago (2014-07-18 10:00:44 UTC) #5

Message was sent while issue was closed.

Change committed as 284064

Expand Messages | Collapse Messages