Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 405433007: IndexedDB: Fix coding style issues c/o cpplint.py (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 5 months ago
Reviewers:
cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Fix coding style issues c/o cpplint.py Most of these are non-const refs that should be pointers. BUG=381456 TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -74 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 14 chunks +27 lines, -27 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 5 chunks +14 lines, -15 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_fake_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_transaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jsbell
cmumford@ - PTAL? (and CQ if it looks good?)
6 years, 5 months ago (2014-07-17 22:58:10 UTC) #1
cmumford
lgtm. P.S. Should probably give third_party/leveldatabase the same treatmemt - it's in worse shape.
6 years, 5 months ago (2014-07-18 18:00:39 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-18 18:00:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/405433007/1
6 years, 5 months ago (2014-07-18 18:01:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 18:01:45 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-18 18:01:46 UTC) #6
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 5 months ago (2014-07-18 18:07:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/405433007/1
6 years, 5 months ago (2014-07-18 18:08:28 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 19:02:27 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 19:16:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 284179

Powered by Google App Engine
This is Rietveld 408576698