chrome/browser/extensions/extension_sync_service.cc - Issue 405433003: Apps&Extensions for supervised users: Allow the custodian to remotely uninstall extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 405433003: Apps&Extensions for supervised users: Allow the custodian to remotely uninstall extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_syncable_service.cc » ('j') | chrome/browser/ui/app_list/app_list_syncable_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_service.cc

diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc

index 95222d401568cc787be27bfecc1f316a161ddc94..5995394dfe22f9b15410b01d6a098f6f6a6173c4 100644

--- a/chrome/browser/extensions/extension_sync_service.cc

+++ b/chrome/browser/extensions/extension_sync_service.cc

@@ -450,10 +450,13 @@ bool ExtensionSyncService::ProcessExtensionSyncDataHelper(

// Handle uninstalls first.

if (extension_sync_data.uninstalled()) {

+ extensions::UninstallReason reason =

+ extension_sync_data.installed_by_custodian() ?

+ extensions::UNINSTALL_REASON_SYNC_BY_CUSTODIAN :

+ extensions::UNINSTALL_REASON_SYNC;

if (!extension_service_->UninstallExtensionHelper(

- extension_service_, id, extensions::UNINSTALL_REASON_SYNC)) {

- LOG(WARNING) << "Could not uninstall extension " << id

- << " for sync";

+ extension_service_, id, reason)) {

+ LOG(WARNING) << "Could not uninstall extension " << id << " for sync";

}

return true;

}