Apps&Extensions for supervised users: Allow the custodian to remotely uninstall extensions.

chrome/browser/ui/app_list/app_list_syncable_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/apps/drive/drive_app_provider.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 99 matching lines @@
       id == extension_misc::kWebStoreAppId)
     return true;
 #if defined(OS_CHROMEOS)
   if (id == file_manager::kFileManagerAppId || id == genius_app::kGeniusAppId)
     return true;
 #endif
   return false;
 }
 
 void UninstallExtension(ExtensionService* service, const std::string& id) {
-  if (service && service->GetInstalledExtension(id))
-    service->UninstallExtension(id, extensions::UNINSTALL_REASON_SYNC, NULL);
+
+  const extensions::Extension* extension =
+      service ? service->GetInstalledExtension(id) : NULL;
+  if (extension) {
+    extensions::UninstallReason reason =
+        extension->was_installed_by_custodian() ?
+            extensions::UNINSTALL_REASON_SYNC_BY_CUSTODIAN :
+            extensions::UNINSTALL_REASON_SYNC;
+    service->UninstallExtension(id, reason, NULL);

[stevenjb, 2014/07/22 00:47:58]

It seems like this should be automatic, or there should be a helper function for
this, since the logic is not specific to the app list sync code.

[Marc Treib, 2014/07/22 09:30:07]

Ack. With the change suggested by kalman, this has become unnecessary. Thanks
for the feedback!

+  }
 }
 
 bool GetAppListItemType(AppListItem* item,
                         sync_pb::AppListSpecifics::AppListItemType* type) {
   const char* item_type = item->GetItemType();
   if (item_type == ExtensionAppItem::kItemType) {
     *type = sync_pb::AppListSpecifics::TYPE_APP;
   } else if (item_type == AppListFolderItem::kItemType) {
     *type = sync_pb::AppListSpecifics::TYPE_FOLDER;
   } else {
@@ skipping 785 matching lines @@
   } else {
     res += " { " + item_name + " }";
     res += " [" + item_ordinal.ToDebugString() + "]";
     if (!parent_id.empty())
       res += " <" + parent_id.substr(0, 8) + ">";
   }
   return res;
 }
 
 }  // namespace app_list